From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6VCKFM0W3WhWIRsAWB0awg (envelope-from ) for ; Wed, 01 Oct 2025 07:55:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=tv2JbKcD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 508A11E0B6; Wed, 01 Oct 2025 07:55:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC7081E047 for ; Wed, 01 Oct 2025 07:55:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4541A3858280 for ; Wed, 1 Oct 2025 11:55:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4541A3858280 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1759319756; bh=HaOftrOVq4V8J8vjQTImdXLlr2iaSyVF0fbbH+JLVAY=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=tv2JbKcDmWmJZd78qoILzHm+KXxJ2LyowndPzxUDkHwpuxSpOKGWQdAIuAvC1JLxX zD/fr+lNqTbNXTYQVsWwH+bA/1MhwDssrw3rgJYy0Sdtw1zznXtjs1glqyurssP87K xAa+mbRdDulEr2mW4qld1eXC67/tkcoDxloaCnbI= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 93E583858430 for ; Wed, 1 Oct 2025 11:55:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93E583858430 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93E583858430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759319703; cv=none; b=OjDFs8G6sqrnTeV9Vb/S4ZcsY6gQztRHrGbL2Sa/+KnQLjP2clLJvB/Z+LsyErLy9S7hSp7L1pK57gFhUU3jbHXcgi2b15Kby9qF6FatPAuZGUgNxEWDN3d7uhGLo1uagxTYlpIaQTD+FsoB7A7YDFLLO/imqSU/5tVAOHsF1gg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759319703; c=relaxed/simple; bh=3quaoIeB+ZdfvPhJtdtXqkxnqsfIn2rwlyGrrCz30z4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:To:From:Subject; b=ezDFUFaNkEgPUvvBfhxvbbouolb43CEAkj98VMJ4ptUDYoQ6W+9QFTK9swwyvEV9XPR4R8fR8H/nhGl/Sedn1wENbVKb0myEv6sL7sKDxXadUG/foudbvgcSCEOGCu+pzVBBa7nmc/gyZbYWhaTX/9W+lCSlnc/16mUC+6Cfoc8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93E583858430 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02BC81F7FD; Wed, 1 Oct 2025 11:55:02 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DFAD913A3F; Wed, 1 Oct 2025 11:55:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OpgSNZUW3WglcwAAD6G6ig (envelope-from ); Wed, 01 Oct 2025 11:55:01 +0000 Message-ID: <47a36f1e-28e8-4cde-92fa-adf255247f70@suse.de> Date: Wed, 1 Oct 2025 13:55:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: gdb-patches , "gdb@sourceware.org" Subject: tclint, pre-commit and patch submissions Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb Reply-To: Tom de Vries Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" Hi, I've recently added a tclint pre-commit hook, and started cleaning the testsuite. The current status is that all gdb.* dirs are done, with the exception of gdb.stabs (which is going to be removed, so I skipped it). My question is what to do with patches adding new test-cases or modifying existing test-cases. If these patches are not tclint-clean, then after commit this command: ... $ pre-commit run tclint --all-files ... will start showing new tclint errors. One thing that could be done at that point is to ask the submitter/committer to fix the tclint errors. But there's no formal agreement atm that this need to be fixed. I've proposed the hook, and Tom Tromey approved it, but that's just two maintainers. So I'd like to know the opinion of other maintainers. Possible outcomes of this discussion could be that: - we get rid of tclint in pre-commit and forget about it - we drop one or more error categories in gdb/tclint.toml - we require submitters to run pre-commit before submission - we make the repo refuse commits that are not pre-commit clean - nothing changes, and submitters can use all/some/no pre-commit hooks for their own submissions Thanks, - Tom