Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Daniel Berlin <dberlin@dberlin.org>
To: Jim Blandy <jimb@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb@sources.redhat.com
Subject: Re: dwarf2read.c doesn't produce LOC_COMPUTED_ARG
Date: Thu, 10 Apr 2003 22:32:00 -0000	[thread overview]
Message-ID: <47CE37C7-6BA4-11D7-953E-000393575BCC@dberlin.org> (raw)
In-Reply-To: <vt2istmov5t.fsf@zenia.red-bean.com>


On Thursday, April 10, 2003, at 06:16  PM, Jim Blandy wrote:

> Daniel Jacobowitz <drow@mvista.com> writes:
>
>> On Wed, Apr 09, 2003 at 11:27:27PM -0500, Jim Blandy wrote:
>>>
>>> I just realized that dwarf2read.c will produce LOC_COMPUTED symbols,
>>> but not LOC_COMPUTED_ARG symbols.  The case for
>>> DW_TAG_formal_parameter in new_symbol doesn't call
>>> var_decode_location; it does what it's always done.
>>>
>>> Is there any reason for this, or was it just an oversight?
>>
>> It was just a lack of time, really.  We've just recently got a PR 
>> about
>> this too.  After I check in the location lists patch I'll try to do
>> LOC_COMPUTED_ARG.
>
> Okay.
>
> I'm glad to hear there wasn't some horrible reason it was going to be
> impossible.

Nope
In fact, it's not that it's never been tried, either.  I actually had 
code around to make LOC_COMPUTED_ARG in dwarf2 just to test the 
interface, it was simply omitted from the patches that went to 
gdb-patches (and to DanJ) to make them smaller.

That said, I never regression tested that part of the patch, it was 
more of a "doesn't seem anything is egregiously wrong here" type thing 
to make sure i caught all the blatantly obvious cases.

So don't be surprised if it breaks something subtle, but don't be 
worried it can't be done.
:)

>

>  I just had a rude awakening regarding why frame-base.[ch]
> will be with us for at least as long as STABS and mdebug are...


  reply	other threads:[~2003-04-10 22:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-10  4:26 Jim Blandy
2003-04-10 12:33 ` Daniel Jacobowitz
2003-04-10 22:15   ` Jim Blandy
2003-04-10 22:32     ` Daniel Berlin [this message]
2003-04-11  2:18     ` Andrew Cagney
2003-04-10 13:30 ` Daniel Berlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47CE37C7-6BA4-11D7-953E-000393575BCC@dberlin.org \
    --to=dberlin@dberlin.org \
    --cc=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox