From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32720 invoked by alias); 11 Jun 2007 10:58:53 -0000 Received: (qmail 32712 invoked by uid 22791); 11 Jun 2007 10:58:53 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Jun 2007 10:58:51 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5BAwmoo102026 for ; Mon, 11 Jun 2007 10:58:48 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5BAwm3i3731706 for ; Mon, 11 Jun 2007 12:58:48 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5BAwlG7021005 for ; Mon, 11 Jun 2007 12:58:47 +0200 Received: from [9.146.224.85] (dev11854.de.ibm.com [9.146.224.85]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5BAwjFv020932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jun 2007 12:58:47 +0200 Message-ID: <466D2A94.1020703@de.ibm.com> Date: Mon, 11 Jun 2007 10:58:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Rob Quill CC: gdb@sourceware.org Subject: Re: Scope Checking Patch References: <466D07FE.4080800@de.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00075.txt.bz2 Rob Quill wrote: > On 11/06/07, Markus Deuling wrote: >> Hi Rob, >> >> I haven't gone through your patch, but I have a suggestion. If I do a >> patch for GDB I do it like that: >> >> a) Checkout current head >> b) Create a copy of that directory e.g. gdb.new >> c) Do my changes in gdb.new >> d) Create patch by: diff -urN gdb/ gdb.new/ > diff-file > > Thanks. I tried this, but I ended up with a 214MB diff file. I'm not > sure why this is, as I did a make distclean on both copies, I think it > may be due to the testsuite results not having been cleaned or > something. Does anyone have any ideas what to do? Hm, I think I haven't pointed it out clearly. Lets assume following directory structure: gdb-6.6/ <- extract gdb-6.6.tar.bz2 gdb.dev/ <- copy of gdb-6.6/ gdb.dev/build <- directory in which you configure & build gdb gdb.dev/gdb <- source tree where you do your changes gdb-6.6/gdb <- original gdb source tree You do a patch now with following command: diff -urN gdb-6.6/gdb/ gdb.dev/gdb > diff-file What you should do is to compare ONLY the source tree in gdb/ directories. To configure & build gdb: cd gdb.dev/ mkdir build cd build/ ../configure --disable-werror make You should always build GDB in a directory separate from source directory. -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com