From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12191 invoked by alias); 11 Jun 2007 08:31:20 -0000 Received: (qmail 12179 invoked by uid 22791); 11 Jun 2007 08:31:19 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Jun 2007 08:31:17 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id l5B8VErF120866 for ; Mon, 11 Jun 2007 08:31:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l5B8VEBd3837960 for ; Mon, 11 Jun 2007 10:31:14 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l5B8VDsn029443 for ; Mon, 11 Jun 2007 10:31:14 +0200 Received: from [9.146.224.85] (dev11854.de.ibm.com [9.146.224.85]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l5B8VBQg029367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jun 2007 10:31:13 +0200 Message-ID: <466D07FE.4080800@de.ibm.com> Date: Mon, 11 Jun 2007 08:31:00 -0000 From: Markus Deuling User-Agent: Thunderbird 1.5.0.10 (X11/20070301) MIME-Version: 1.0 To: Rob Quill CC: gdb@sourceware.org Subject: Re: Scope Checking Patch References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00068.txt.bz2 Hi Rob, I haven't gone through your patch, but I have a suggestion. If I do a patch for GDB I do it like that: a) Checkout current head b) Create a copy of that directory e.g. gdb.new c) Do my changes in gdb.new d) Create patch by: diff -urN gdb/ gdb.new/ > diff-file Then you the two diff files in one file and its better readable. Also its easier to apply just one file instead of two. Regards, Markus Rob Quill wrote: > Hi all, > > This is the first patch I have ever submitted to an open source > project, so I'm a little bit unsure of the process. The patch adds the > ability to check if a variable is in scope, as descibed here: > > http://sourceware.org/ml/gdb/2006-11/msg00149.html > > I have attached the diffs for the two files I've changed. However, I > am seeing some regressions against the current cvs, which I can't > understand, so I was wondering if a) the regressions happen for anyone > esle? (which presumably it does), b) if anyone could offer any > suggestions as to the cause, and c) give thier opinions on the patch. > > The patch allows the scope of constants, variables and variables in > classes/structures, by using $in_scope(variable_name) as an > expression, with value 1 if variable_name is in scope and 0 if it is > not. > > Any help and thoughts you can offer is much appreciated. > > Thanks, > > Rob > -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com