From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31256 invoked by alias); 9 Mar 2007 04:32:40 -0000 Received: (qmail 31248 invoked by uid 22791); 9 Mar 2007 04:32:39 -0000 X-Spam-Check-By: sourceware.org Received: from terminus.zytor.com (HELO terminus.zytor.com) (192.83.249.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Mar 2007 04:32:34 +0000 Received: from [172.27.0.16] (c-67-180-238-27.hsd1.ca.comcast.net [67.180.238.27]) (authenticated bits=0) by terminus.zytor.com (8.13.8/8.13.7) with ESMTP id l294V5ea029520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 8 Mar 2007 20:31:05 -0800 Message-ID: <45F0E309.70403@zytor.com> Date: Fri, 09 Mar 2007 04:32:00 -0000 From: "H. Peter Anvin" User-Agent: Thunderbird 1.5.0.9 (X11/20070212) MIME-Version: 1.0 To: David Miller CC: anton@samba.org, hch@infradead.org, arjan@infradead.org, zippel@linux-m68k.org, dmlb2000@gmail.com, linux-kernel@vger.kernel.org, gdb@sourceware.org Subject: Re: PAGE_SIZE Availability Inconsistency References: <20070308.134825.45514445.davem@davemloft.net> <20070309024324.GA24695@kryten> <45F0E014.8060907@zytor.com> <20070308.202718.68040662.davem@davemloft.net> In-Reply-To: <20070308.202718.68040662.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Status: Clean Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00153.txt.bz2 David Miller wrote: > From: "H. Peter Anvin" > Date: Thu, 08 Mar 2007 20:18:28 -0800 > >> Anton Blanchard wrote: >>> The other option is to create a v3 swap format that doesnt use any >>> PAGE_SIZE parameters. >> The best thing to do would be to look for the magic both at PAGE_SIZE >> (for compatibility) and MIN_PAGE_SIZE (for sanity.) > > That might work, but a large part of me says to go for v3 > and do it cleanly. The advantage would be that it wouldn't require a v3 for platforms for which MIN_PAGE_SIZE == PAGE_SIZE, which accounts for a very large percentage of systems. You still have to look for the darn magic in two places, so there is no reason for it to be different. -hpa