From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16704 invoked by alias); 19 Apr 2016 19:26:32 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 15993 invoked by uid 89); 19 Apr 2016 19:26:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*UA:FreeBSD, H*u:FreeBSD, Hx-languages-length:1382, baldwin X-HELO: bigwig.baldwin.cx Received: from bigwig.baldwin.cx (HELO bigwig.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Tue, 19 Apr 2016 19:26:21 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id DC325B982; Tue, 19 Apr 2016 15:26:18 -0400 (EDT) From: John Baldwin To: gdb@sourceware.org Cc: Pedro Alves Subject: Re: C++ conversion status update Date: Tue, 19 Apr 2016 19:26:00 -0000 Message-ID: <4587615.ZrrbCebxpz@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <57151080.3000900@redhat.com> References: <565460FB.6070103@redhat.com> <5711857D.8030708@redhat.com> <57151080.3000900@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-04/txt/msg00029.txt.bz2 On Monday, April 18, 2016 05:51:12 PM Pedro Alves wrote: > On 04/16/2016 01:21 AM, Pedro Alves wrote: > > Yes, agreed. I've sent a patch that does that to the > > list now: > > > > https://sourceware.org/ml/gdb-patches/2016-04/msg00374.html > > > > If you could give it a try it'd be much appreciated. I've pushed > > it to the users/palves/ptrace-detection branch (at sourceware.org) > > as well, for convenience. > > FYI, a fix is in master now. Thanks, I was able to test it and it works great on FreeBSD/amd64. I have a set of simple C++ build fixes for fbsd-nat.c I will post to patches@ in a bit. The only remaining issue is that FreeBSD's stack_t defines ss_sp as char * instead of void *. Apparently 4.4BSD had this and the other BSD's fixed this long ago. When I first ran into this in January I fixed FreeBSD's trunk, so 11.0 will ship with a proper ss_sp of void *, but older releases will not. The affected code is in setup_alternate_signal_stack() in gdb/main.c where ss_sp is assigned to the void * returned from xmalloc(). I was torn between just supporting C++ builds on FreeBSD 11 and later, or adding autoconf glue for just this part. However, given that it seems like the recent discussion is to deprecate C mode in the near future, it seems like I should do the latter. Do you have any better suggestions? -- John Baldwin