From: Nitin Gupta <ngupta@mvista.com>
To: gdb@sourceware.org
Cc: Jim Blandy <jimb@codesourcery.com>, Rob Quill <rob.quill@gmail.com>
Subject: [PATCH] Fix for thread debugging in the presence of software single step
Date: Tue, 28 Nov 2006 18:42:00 -0000 [thread overview]
Message-ID: <456C82F7.4030903@mvista.com> (raw)
Following patch fixes for thread debugging in the presence of software
single step:
Only allow one thread to single-step if SOFTWARE_SINGLE_STEP_P ()
If it looks OK, Could someone please check it in?
Index: gdb-6.5/gdb/infrun.c
===================================================================
--- gdb-6.5.orig/gdb/infrun.c
+++ gdb-6.5/gdb/infrun.c
@@ -618,10 +618,11 @@
}
if ((scheduler_mode == schedlock_on)
- || (scheduler_mode == schedlock_step
- && (step || singlestep_breakpoints_inserted_p)))
+ || (scheduler_mode == schedlock_step && step)
+ || singlestep_breakpoints_inserted_p)
{
/* User-settable 'scheduler' mode requires solo thread resume. */
+ /* Software single-step doesn't work right with multiple
threads. */
resume_ptid = inferior_ptid;
}
next reply other threads:[~2006-11-28 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 18:42 Nitin Gupta [this message]
2006-11-28 18:47 ` Daniel Jacobowitz
2006-11-28 19:01 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456C82F7.4030903@mvista.com \
--to=ngupta@mvista.com \
--cc=gdb@sourceware.org \
--cc=jimb@codesourcery.com \
--cc=rob.quill@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox