Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Maxim Grigoriev <maxim@tensilica.com>
To: gdb@sourceware.org
Subject: Xtensa port
Date: Thu, 28 Sep 2006 01:15:00 -0000	[thread overview]
Message-ID: <451B223C.6090204@hq.tensilica.com> (raw)

I just sent an updated patch with the following comments:

After some investigation, it turns out that the get_fp_num() function, 
which was "grubbing around in the private data structures of the symbol 
reader", is not needed at all.  Perhaps that code was left over from an 
earlier version of GDB. Stack unwinding on Xtensa can be done using the 
register windows -- it requires neither prologue analysis to find the 
frame pointer nor DWARF unwind info.  The only thing the get_fp_num() 
function was used for was identifying frames, but it seems like we can 
just use the stack pointer for the frame ID.  (Is that right?)  I've 
changed the code to do this and it appears to work fine: no DejaGnu 
regression has been detected, and manual testing on alloca-tests hasn't 
exposed anything.

The other suggestions that I've received so far were easy to use and 
I've done that.  By the way, I also removed the line to use the 
dwarf2_frame_sniffer, because DWARF unwind info is not currently used 
for Xtensa.

Maxim Grigoriev
Tensilica, Inc.
3255-6 Scott Boulevard
Santa Clara, CA 95054-3013
(w) 408-566-1770


             reply	other threads:[~2006-09-28  1:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28  1:15 Maxim Grigoriev [this message]
     [not found] <45142A88.7000805@hq.tensilica.com>
     [not found] ` <20060922190726.GA8221@nevyn.them.org>
2006-09-23  0:28   ` Maxim Grigoriev
2006-09-23 14:26     ` Daniel Jacobowitz
  -- strict thread matches above, loose matches on Subject: below --
2006-09-22 18:30 Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451B223C.6090204@hq.tensilica.com \
    --to=maxim@tensilica.com \
    --cc=gdb@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox