From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4717 invoked by alias); 9 May 2006 10:08:13 -0000 Received: (qmail 4668 invoked by uid 22791); 9 May 2006 10:08:12 -0000 X-Spam-Check-By: sourceware.org Received: from intranet.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.6) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 May 2006 10:08:07 +0000 Received: (qmail 12825 invoked from network); 9 May 2006 10:08:04 -0000 Received: from unknown (HELO ?192.168.189.145?) (nathan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 May 2006 10:08:04 -0000 Message-ID: <446069FB.40200@codesourcery.com> Date: Tue, 09 May 2006 12:19:00 -0000 From: Nathan Sidwell User-Agent: Mozilla Thunderbird 1.0.8 (X11/20060502) MIME-Version: 1.0 To: Jean-Rene Peulve CC: gdb@sources.redhat.com, Daniel Jacobowitz Subject: Re: gdbserver for m68k-uclinux References: <445F5278.3000900@codesourcery.com> <6.1.0.6.0.20060509114307.00a0e780@pop.wanadoo.fr> In-Reply-To: <6.1.0.6.0.20060509114307.00a0e780@pop.wanadoo.fr> Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00084.txt.bz2 Jean-Rene Peulve wrote: > Hi Nathan, > Oups: I resend this because the previous email was html and got bounced > by gdb@sources.redhat.com Thanks for testing the patch out! > I have been forced to change your patch to make it works. > > 1) missing return in server.c The return you've added is unnecessary. > 2) I also add an fprintf to stderr with the address of the text and data > section to allow the use of add-symbol_file command which requires these > address. > The response to qOffsets being hidden by gdb, I then can get it from > the target console or telnet. Dan, I'll leave this change for you to decide. I don't understand the usage here. Why is it not necessary to know the text_end address in this case, for instance? > + if (the_target->read_offsets (&text, &data)) { > + sprintf (own_buf, "Text=%lX;Data=%lX;Bss=%lX", > + (long)text, (long)data, (long)data); > + return; This return is not needed, why did you find it necessary? > + } > + else > + write_enn (own_buf); > + > + return; > + } nathan -- Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk