From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5035 invoked by alias); 29 Apr 2005 16:46:55 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 32345 invoked from network); 29 Apr 2005 16:43:42 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 29 Apr 2005 16:43:42 -0000 Received: (qmail 330 invoked from network); 29 Apr 2005 16:43:41 -0000 Received: from localhost (HELO ?65.78.187.111?) (mitchell@127.0.0.1) by mail.codesourcery.com with SMTP; 29 Apr 2005 16:43:41 -0000 Message-ID: <42726437.9050208@codesourcery.com> Date: Fri, 29 Apr 2005 16:47:00 -0000 From: Mark Mitchell User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) MIME-Version: 1.0 To: Christopher Faylor CC: paul@codesourcery.com, gdb@sourceware.org Subject: Re: Windows support in GDB References: <200504291513.j3TFDhjx021040@elgar.sibelius.xs4all.nl> <20050429153146.GA27362@nevyn.them.org> <20050429160040.GH10017@trixie.casa.cgf.cx> <42725D6A.7040103@codesourcery.com> <20050429162732.GA12864@trixie.casa.cgf.cx> In-Reply-To: <20050429162732.GA12864@trixie.casa.cgf.cx> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-04/txt/msg00225.txt.bz2 Christopher Faylor wrote: > However, now that the patches are finally here, I have to say that I > sort of share Mark K's concerns. I'm wondering if we are on a slippery > slope and (to mix a metaphor) will be subjecting gdb to a > death-by-inches as we slowly add ifdefs throughout the configury and > code. I think it's a funny time to get concerned -- we're done. :-) There are no more cuts coming, so as long as we're not bleeding to death yet, we're not going to die. Plenty of GNU software has similar patches to support running on MinGW. GDB itself already has 2500 lines of code in win32-nat.c, some of which I would imagine is rather more opaque to POSIX programmers than anything we've added. We made these changes with no algorithmic modifications to GDB, no perversions of its core design, etc. What's the failure mode going to be? If a POSIX person adds a use of non-Windows function, without appropriate #ifdef, then the Windows side of things will break. At that point, assuming that people are noticing (which we will!), we'll fix that. I certainly don't think the entire codebase will be littered with HANDLEs and ReadFileEx, or transformed into a multi-threaded application with a Windows event loop in the middle of it, or anything like that. -- Mark Mitchell CodeSourcery, LLC mark@codesourcery.com (916) 791-8304