Re: [PATCH/RFA] sim autoconf conversion fallout

[Andrew Cagney <cagney@gnu.org>]

Mark Kettenis wrote:
> There still a lot of breakage in the sim tree:

Looks under desk, nope, no fire.  I guess MIPS, mn10300, and erc32 
qualify as "a lot" :-)

> * Several simulators no longer build because the common directory
>   isn't configured.  AFAICT all similators need that directory, so I
>   propose the attached patch.

This problem applied to just two simulators:  MIPS and mn10300.  I've 
fixed the error and confirmed that the MIPS builds.

> * The --enable-sim option is essentially a no-op now, since all
>   simulators are built unconditionally if gdb is configured for a
>   matching target.  Why has the option been retained while all the
>   logic that used it is gone?  Why was the logic removed in the first
>   place?

--enable-sim always was a no-op (unlike --disable-sim).   The only 
exception was for erc32 and since that doesn't build at all I've now 
disabled it.

> * In the past several simulators were only built when compiling with
>   gcc.  That code was ripped out.  Why?

Why not.

 From '98 (although I suspect '96):
   # The PowerPC simulator uses the GCC extension long long as well as
   # ANSI prototypes, so don't enable it for random host compilers
   # unless asked to.
hence the test.

Fast forward 7 years - even GCC now assums ISO-C and long-long is a 
defacto "standard".

Andrew