From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2924 invoked by alias); 14 Jul 2004 19:29:03 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 2915 invoked from network); 14 Jul 2004 19:29:03 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 14 Jul 2004 19:29:03 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6EJT2e3030866 for ; Wed, 14 Jul 2004 15:29:03 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6EJT2001183; Wed, 14 Jul 2004 15:29:02 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3E9DF2B9D; Wed, 14 Jul 2004 15:28:50 -0400 (EDT) Message-ID: <40F58971.7000304@gnu.org> Date: Wed, 14 Jul 2004 19:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: "Martin M. Hunt" , Mark Kettenis Cc: gdb@sources.redhat.com Subject: Re: dwarf2-frame.c question for maintainers References: <1089749730.3026.18.camel@dragon> <40F56CCA.5080106@gnu.org> <1089827266.3010.2.camel@dragon> In-Reply-To: <1089827266.3010.2.camel@dragon> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00145.txt.bz2 >>> How come extract_typed_address, in read_reg, doesn't sign extend? > > > I should have explained that. It does. However extract_typed_address is > incorrect because it makes the invalid assumption that sizeof(address) > == sizeof(register). So that has to go and be replaced with something > like > extract_signed_integer (buf, register_size (current_gdbarch, regnum)); You mean the builtin_type_void_data_ptr parameter to extract_typed_address? Ah. I see builtin_type_void_data_ptr dates back to 1.1 (Mark?). It could instead use the register's type? Andrew