From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12695 invoked by alias); 21 Sep 2017 18:18:46 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 12636 invoked by uid 89); 21 Sep 2017 18:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=H*i:sk:347AE88, H*f:sk:347AE88, H*M:9922 X-HELO: mail-qt0-f172.google.com Received: from mail-qt0-f172.google.com (HELO mail-qt0-f172.google.com) (209.85.216.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 18:18:44 +0000 Received: by mail-qt0-f172.google.com with SMTP id 47so6788968qts.10 for ; Thu, 21 Sep 2017 11:18:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lMO5XeZVevm3Xzz1I11+HjNAHCpmCoR64FgevKimi0s=; b=pH+s6yrkVe/3Fc4Bk9mUriE3PmHV/hvWMucFOqRzSb/P1GUXguXJ3dSZSwNZ5Y9WEg vZBkcMarKKpAHz6Ty3AjwpaXUdsprBrJLAXLn7Y7HEbZeiB9HtX/JD17m8VkQ7acLMcx EmAiEoWe1fL8rLVmgusyLuklyp5Tq4jbReU1MNzkdO5GBtJvMX775soc5KL9isxvX7m5 L8p3qK9BkDKxXGPUix+BPqwL38zWl7FoKMTpvsHj+6mlz9H/e/dsLllIE1O6ix/a+U5v HA4YKAa5uKQYpwcpTu3jiNE855VjktfBShHZKR8ZHY8GlF/Y7FP7VzIyQsbTYAGADkTq omVA== X-Gm-Message-State: AHPjjUj04aQY0PhBsaVIZvtXrPph7eGRdWEpYHLMhmPT5aHYhZBqjtLE bqXtBL8UpfJRXr7K7/Mj71P8UQ== X-Google-Smtp-Source: AOwi7QADO6Yt18jXMN5gp4ZkAwsMGuEUxOVAhw/c5LlksG7i1fQzYqpE4PNiO7G/pKt+8fs4kEJ2Aw== X-Received: by 10.200.43.42 with SMTP id 39mr4866441qtu.51.1506017922513; Thu, 21 Sep 2017 11:18:42 -0700 (PDT) Received: from [192.168.222.10] ([184.69.210.114]) by smtp.gmail.com with ESMTPSA id h29sm1442164qtk.29.2017.09.21.11.18.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 11:18:41 -0700 (PDT) Subject: Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc. To: Richard Biener , gcc@gcc.gnu.org, Thomas Schwinge , gdb@sourceware.org, binutils@sourceware.org, libc-alpha@sourceware.org References: <87zi9oj8rl.fsf@euler.schwinge.homeip.net> <347AE883-971C-447C-AB07-43F7F70F25D3@gmail.com> From: Carlos O'Donell Message-ID: <4056e466-3055-455b-9922-55497d21fd80@redhat.com> Date: Thu, 21 Sep 2017 18:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <347AE883-971C-447C-AB07-43F7F70F25D3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00095.txt.bz2 On 09/21/2017 11:56 AM, Richard Biener wrote: >> Not yet. > > I think given an OK from an official reviewer entitles you to commit > it indeed IS matching the formal statement. It better does... Isn't it better to be explicit about this; rather than assuming? >> All of this is nothing compared to the work of doing the review. > > Depends on the complexity of the patch... ... depends on your ability to create quick paste hot keys :} -- Cheers, Carlos.