From: Andrew Cagney <cagney@gnu.org>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: Michael Elizabeth Chastain <mec.gnu@mindspring.com>,
gdb@sources.redhat.com
Subject: Re: [RFA]: Patch for regression with huge integer
Date: Thu, 26 Feb 2004 23:09:00 -0000 [thread overview]
Message-ID: <403E7C95.8070605@gnu.org> (raw)
In-Reply-To: <403E7028.1020404@redhat.com>
> 2004-02-26 Jeff Johnston <jjohnstn@redhat.com>
>
> * valprint.h (print_hex_chars, print_char_chars): New prototypes.
> * valprint.c (print_hex_chars): Change from static to external.
> (print_char_chars): New function.
> * printcmd.c (print_scalar_formatted): For integer and enum types
> that are longer than LONGEST, perform processing via appropriate
> print_*_chars routines.
Yes.
Coding nit though, "||" and "&&" go on the lhs, not rhs.
Andrew
> + if (len > sizeof(LONGEST) &&
> + (TYPE_CODE (type) == TYPE_CODE_INT ||
> + TYPE_CODE (type) == TYPE_CODE_ENUM))
next prev parent reply other threads:[~2004-02-26 23:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 19:55 Michael Elizabeth Chastain
2004-02-23 20:44 ` Andreas Schwab
2004-02-23 21:27 ` Mark Kettenis
2004-02-23 21:31 ` Andrew Cagney
2004-02-23 22:25 ` Jeff Johnston
2004-02-26 22:16 ` [RFA]: Patch for " Jeff Johnston
2004-02-26 23:09 ` Andrew Cagney [this message]
2004-02-26 23:17 ` Daniel Jacobowitz
2004-02-26 23:48 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403E7C95.8070605@gnu.org \
--to=cagney@gnu.org \
--cc=gdb@sources.redhat.com \
--cc=jjohnstn@redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox