[PATCH]: Re: gdb.base/pending.exp failures

[Jeff Johnston <jjohnstn@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1492 bytes --]

I have just checked in the accompanying patch which takes Daniel's suggestion of 
indirectly calling pendfunc1 from the main program.  I have tested it on both 
ia64-linux and i686-linux.

-- Jeff J.

2004-02-04  Jeff Johnston  <jjohnstn@redhat.com>

         * gdb.base/pendshr.c (pendfunc): New function that calls
         pendfunc1.
         * gdb.base/pending.c: Call pendfunc instead of pendfunc1.



Jeff Johnston wrote:
> Daniel Jacobowitz wrote:
> 
>> Just a note of probable-cause: Jeff, on which platforms did you test
>> this testcase?  I bet it wasn't i386-linux.
>>  
>>
> 
> You're right.  I tested ia64, not i386.
> 
>> On Wed, Feb 04, 2004 at 04:01:21PM -0800, David Carlton wrote:
>>  
>>
>>> (gdb) break pendfunc1
>>>
>>> Breakpoint 1 at 0x804839c
>>>
>>> (gdb) FAIL: gdb.base/pending.exp: set pending breakpoint
>>>   
>>
>>
>> This function is in a shared library that hasn't been loaded yet. 
>> However, on i386-linux (and many other platforms), the call will go
>> through a PLT entry, and the entry in the application's symbol table
>> will appear as an SHN_UNDEF symbol with a non-zero address pointing at
>> the PLT entry.  GDB will re-resolve the breakpoint after shared
>> libraries have been loaded.  This is already-existing functionality.
>>
>> If you don't want to use dlopen in the test, try setting breakpoints on
>> a function not called directly from the executable (i.e. called from
>> within the library).
>>
>>  
>>
> Thanks for the explanation.
> 
> 

[-- Attachment #2: pendfix.patch --]
[-- Type: text/plain, Size: 1000 bytes --]

Index: pending.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pending.c,v
retrieving revision 1.1
diff -u -p -r1.1 pending.c
--- pending.c	2 Feb 2004 21:14:33 -0000	1.1
+++ pending.c	5 Feb 2004 01:17:48 -0000
@@ -23,13 +23,13 @@
 
 int k = 0;
 
-extern void pendfunc1 (int x);
+extern void pendfunc (int x);
 
 int main()
 {
-  pendfunc1 (3); /* break main here */
-  pendfunc1 (4);
+  pendfunc (3); /* break main here */
+  pendfunc (4);
   k = 1;
-  pendfunc1 (3);
+  pendfunc (3);
   return 0;
 }
Index: pendshr.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pendshr.c,v
retrieving revision 1.1
diff -u -p -r1.1 pendshr.c
--- pendshr.c	2 Feb 2004 21:14:33 -0000	1.1
+++ pendshr.c	5 Feb 2004 01:17:48 -0000
@@ -26,3 +26,8 @@ void pendfunc1 (int x)
   int y = x + 4;
   printf ("in pendfunc1, x is %d\n", x);
 }
+
+void pendfunc (int x)
+{
+  pendfunc1 (x);
+}