Re: [PATCH] contrib: Add autoregen.py

Simon Marchi via Gdb
2024-04-19T17:51:44Z

On 2024-04-19 12:23, Tom Tromey wrote:
>>>>>> Christophe Lyon via Gdb <gdb@sourceware.org> writes:
>
>> This script is a copy of the current script used by Sourceware's
>> autoregen buildbots.
>
>> It is intended as a helper to regenerate files managed by autotools
>> (autoconf, automake, aclocal, ....), as well as the toplevel
>> Makefile.in which is created by autogen.
>
>> Other files can be updated when using maintainer-mode, but this is not
>> covered by this script.
>
> Thanks for working on this.
>
>> +# these directories are known to be re-generatable with a simple autoreconf
>> +# without special -I flags
>
> Can other directories be updated to this same standard? If not, why
> not? I'm somewhat uncomfortable with the number of special cases in
> this script.
>
> I was hoping it would be more like:
>
> top level -> autogen + autoconf
> anywhere else with configure.{ac,in} -> autoreconf
>
> Tom

I wrote the initial version of the autoreconf support in this script,
originally it only had gdb, gdbserver and gdbsupport. But Christophe
later added all the directories that currently work with a simple
autoreconf. At this point, I think it would make sense to flip the
logic and list only the directories that don't work with a simple
autoreconf, and then work on reducing that list to 0.

Simon