From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-16125-listarch-gdb=sources.redhat.com@sources.redhat.com>
Received: (qmail 5954 invoked by alias); 4 Nov 2003 23:51:40 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 5940 invoked from network); 4 Nov 2003 23:51:38 -0000
Received: from unknown (HELO localhost.redhat.com) (207.219.125.105)
  by sources.redhat.com with SMTP; 4 Nov 2003 23:51:38 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 3D42A2B8F; Tue,  4 Nov 2003 18:51:29 -0500 (EST)
Message-ID: <3FA83B81.2070605@redhat.com>
Date: Tue, 04 Nov 2003 23:51:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: gdb@sources.redhat.com
Cc: David Carlton <carlton@kealia.com>
Subject: Re: A gdb+bfd string pool?
References: <3FA27C9B.1000702@redhat.com> <yf2sml5jreg.fsf@hawaii.kealia.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-11/txt/msg00032.txt.bz2

> our lack of const-correctness when
> dealing with names makes me even more nervous.

Can someone please convince me that this ...

> struct partial_symbol *
> fixup_psymbol_section (struct partial_symbol *psym, struct objfile *objfile)
> {
>   if (!psym)
>     return NULL;
> 
>   if (SYMBOL_BFD_SECTION (psym))
>     return psym;
> 
>   fixup_section (&psym->ginfo, objfile);
> 
>   return psym;
> }

and this:

> 	if (SYMBOL_SECTION (*psym) >= 0)
> 	  SYMBOL_VALUE_ADDRESS (*psym) += ANOFFSET (delta,

aren't modifying the bcached minimal symbol? :-(

Andrew