From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22020 invoked by alias); 15 Oct 2003 22:41:54 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 22012 invoked from network); 15 Oct 2003 22:41:53 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 15 Oct 2003 22:41:53 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A36952B89 for ; Wed, 15 Oct 2003 18:41:54 -0400 (EDT) Message-ID: <3F8DCD32.4070009@redhat.com> Date: Wed, 15 Oct 2003 22:41:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb@sources.redhat.com Subject: Should push_target pop all targets? Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00206.txt.bz2 Hello, The current push_target code: > /* Find the proper stratum to install this target in. */ > > for (prev = NULL, cur = target_stack; cur; prev = cur, cur = cur->next) > { > if ((int) (t->to_stratum) >= (int) (cur->target_ops->to_stratum)) > break; > } > > /* If there's already targets at this stratum, remove them. */ only pops targets at the stratum level being pushed. Doing this - changing the target underneath ones feet - just scares me. I think this should be changed so that all targets above that one get poped. If they are still needed, they can be re-pushed. I suspect this will affect core-file and thread targets ... Andrew