From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31273 invoked by alias); 9 Oct 2003 13:51:17 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 31266 invoked from network); 9 Oct 2003 13:51:16 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 9 Oct 2003 13:51:16 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7B4392B8E; Thu, 9 Oct 2003 09:51:14 -0400 (EDT) Message-ID: <3F8567D2.3020902@redhat.com> Date: Thu, 09 Oct 2003 13:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb@sources.redhat.com Subject: Re: "struct target_ops" -> "struct gdbtarg" || "struct target" References: <3F856516.9020904@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-10/txt/msg00147.txt.bz2 > Hello, > > The current "target_ops" structure appeared with GDB 4. The original implementation containing only methods. Since then the target_ops have evolved to include data vis: > > struct section_table > *to_sections; > struct section_table > *to_sections_end; > > I think, the vector should be re-named to "struct target" or "struct gdbtarg" (consistent with gdbarch, and more name space proof) so that it correctly reflects its current implementation. > > I'd like to do this now, before the target methods start being explicitly parameterized with their target vector. I should note that an alternative is to have "struct gdbarch" as the object and "struct target_ops" as the methods vis: struct target { .. data elements ...; const struct target_ops *ops; }; Andrew