From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19751 invoked by alias); 9 Jul 2003 14:24:22 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 19744 invoked from network); 9 Jul 2003 14:24:22 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 9 Jul 2003 14:24:22 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DE19B2B5F; Wed, 9 Jul 2003 10:24:16 -0400 (EDT) Message-ID: <3F0C2590.4090809@redhat.com> Date: Wed, 09 Jul 2003 14:24:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andreas Schwab Cc: gdb@sources.redhat.com Subject: Re: A matter of taste? References: <20030709135543.GO12368@cygbert.vinschen.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-07/txt/msg00095.txt.bz2 > Corinna Vinschen writes: > > |> Hi, > |> > |> I'm currently substituting a bunch of calls to REGISTER_RAW_SIZE. > |> Since REGISTER_RAW_SIZE should be removed entirely, I was wondering > |> how to do it most nicely. > |> > |> What I don't quite get is the implementation of function register_size > |> in regcache.c. It retrieves the size of the regsiter from the > |> regcache and then checks twice(!) if that size equals REGISTER_RAW_SIZE. > > The second check probabably should have been against > REGISTER_VIRTUAL_SIZE. but it turned out that enabling it would have broken some targets :-( > |> If I understand that correctly, a multi-arched target which got rid of > |> REGISTER_RAW_SIZE can't use register_size () since the REGISTER_RAW_SIZE > |> calls in register_size will raise an internal_error in > |> gdbarch_deprecated_register_raw_size(). > > If you don't define REGISTER_RAW_SIZE then it is defined to > generic_register_size, which uses TYPE_LENGTH. Yes. > |> What is that good for? And what's the substitute for a target with > |> no REGISTER_RAW_SIZE implementation? > > Just use register_size. Works fine on m68k. > > Andreas. I'll adjust the comments. Andrew