Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb@sources.redhat.com
Subject: Re: Crasher in dwarf2-frame.c - memory reuse
Date: Tue, 17 Jun 2003 02:57:00 -0000	[thread overview]
Message-ID: <3EEE82DA.50003@redhat.com> (raw)
In-Reply-To: <20030616215412.GA12729@nevyn.them.org>

> On Mon, Jun 16, 2003 at 05:00:20PM -0400, Andrew Cagney wrote:
> 
>> >So, reread_symbols frees the objfile, but does not clear sym_private. 
>> >Clearing it in reread_symbols fixes the crash, but presumably leaks 
>> >memory. How are we supposed to clean up the FDE list?
> 
>> 
>>       fde = (struct dwarf2_fde *)
>>         obstack_alloc (&unit->objfile->psymbol_obstack,
>>                        sizeof (struct dwarf2_fde));
>> 
>> so won't the symbol table free, free that memory?
> 
> 
> Silly me.  I thought it was malloc'd.  In that case the fix is obvious;
> I'll get it in a little bit.

[it was one of the things I noted when giving marks patch the once over 
- it got rid of michaelL's memory leak]

BTW, there are lots of other places that should also use obstacks - the 
architecture vector for instance.

Andrew



      reply	other threads:[~2003-06-17  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-16 13:49 Daniel Jacobowitz
2003-06-16 21:00 ` Andrew Cagney
2003-06-16 21:54   ` Daniel Jacobowitz
2003-06-17  2:57     ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EEE82DA.50003@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox