From: Andrew Cagney <ac131313@redhat.com>
To: "Theodore A. Roth" <troth@openavr.org>
Cc: gdb@sources.redhat.com
Subject: Re: DEPRECATED_REGISTER_BYTES and remote targets
Date: Tue, 03 Jun 2003 21:12:00 -0000 [thread overview]
Message-ID: <3EDD0F35.1040508@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.53.0306031332410.17269@knuth.amplepower.com>
> Hi,
>
> In trying to remove deprecated gdbarch methods from the avr port, I've
> got a problem with 'g' packets.
>
> In remote_fetch_registers(), the for loop that converts the target hex
> reply to gdb native int uses rs->sizeof_g_packet as the loop stop
> condition.
>
> Digging further, I see in init_remote_state() that the sizeof_g_packet
> field is set to DEPRECATED_REGISTER_BYTES, but since I've removed it,
> sizeof_g_packet is set to zero.
>
> Thus, my problem is that the target reply is never converted to an
> integer and gdb reports that the PC is 0x30303030 instead of 0x0. Fun,
> no?
>
> So, should I still set the DEPRECATED_REGISTER_BYTES method or is this
> a bug in init_remote_state()?
It's a bug in init_remote_state(). If !DEPRECATED_REGISTER_BYTES_P()
it can be computed by accumulating the size of all registers.
Andrew
prev parent reply other threads:[~2003-06-03 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-03 20:39 Theodore A. Roth
2003-06-03 21:12 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EDD0F35.1040508@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb@sources.redhat.com \
--cc=troth@openavr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox