From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11572 invoked by alias); 27 Jan 2003 17:30:26 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 11564 invoked from network); 27 Jan 2003 17:30:24 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by 172.16.49.205 with SMTP; 27 Jan 2003 17:30:24 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1AAA8406A; Mon, 27 Jan 2003 12:30:22 -0500 (EST) Message-ID: <3E356CAD.1000306@redhat.com> Date: Mon, 27 Jan 2003 17:30:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb@sources.redhat.com Subject: Re: gdb_indent vs. dwarf2read References: <20030127031101.GA17969@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00434.txt.bz2 > What do people think about adding "-T bfd -T asection" to gdb_indent.sh? > That's the majority style in current GDB, and we do it for some other > similar types. I thought they were already.... > [I'd like to re-indent dwarf2read.c, so I was looking over the results of > gdb_indent.sh on it before posting the patch. Other churn: structs moved > from two spaces indented to the left column Structs should not be indented two spaces. There was one release of indent that did the two space struct. GDB, unfortunatly, happened to do its jumbo re-indent using that version. Ever since then, re-indents have been `fixing' this foobar. > which matches the general style > in GDB; and comments like: > 1) foo > bar > reindented to > 1) foo > bar Can you give a real example? It might be a bug. There is also the no-indent comment mechanism for comments that really should not be re-indented. > . Should we slavishly obey GNU indent in this, or should I reformat the > comments by hand before posting the reindentation patch?] GDB's indentation is defined by the output of indent. That one isn't open to negotation. Andrew