From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-10821-listarch-gdb=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 13537 invoked by alias); 18 Oct 2002 23:41:53 -0000
Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb/>
List-Post: <mailto:gdb@sources.redhat.com>
List-Help: <mailto:gdb-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-owner@sources.redhat.com
Received: (qmail 13521 invoked from network); 18 Oct 2002 23:41:52 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 18 Oct 2002 23:41:52 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9INKpw29319
	for <gdb@sources.redhat.com>; Fri, 18 Oct 2002 19:20:51 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9INfol31016
	for <gdb@sources.redhat.com>; Fri, 18 Oct 2002 19:41:51 -0400
Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g9INfnD07727;
	Fri, 18 Oct 2002 16:41:49 -0700
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 149B83E0F; Fri, 18 Oct 2002 19:41:51 -0400 (EDT)
Message-ID: <3DB09C3E.9060706@redhat.com>
Date: Fri, 18 Oct 2002 16:41:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb@sources.redhat.com, cagney@redhat.com
Subject: Re: MIPS targets broken by dummy frame/regcache changes
References: <20021010205112.GA26436@nevyn.them.org> <20021014174556.GA17948@nevyn.them.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-10/txt/msg00145.txt.bz2


> @@ -28,9 +29,7 @@
>  int
>  mips_linux_cannot_fetch_register (int regno)
>  {
> -  if (regno >= FP_REGNUM)
> -    return 1;
> -  else if (regno == PS_REGNUM)
> +  if (regno == PS_REGNUM)
>      return 1;
>    else if (regno == ZERO_REGNUM)
>      return 1;
> @@ -41,9 +40,7 @@ mips_linux_cannot_fetch_register (int re
>  int
>  mips_linux_cannot_store_register (int regno)
>  {
> -  if (regno >= FP_REGNUM)
> -    return 1;
> -  else if (regno == PS_REGNUM)
> +  if (regno == PS_REGNUM)
>      return 1;
>    else if (regno == ZERO_REGNUM)
>      return 1;
> 
> It's wrong.  First of all, you changed the behavior for registers above
> FP_REGNUM, like UNUSED_REGNUM.  Secondly, FP_REGNUM did not become OK
> to fetch/store after this patch.  Just the numbering changed.
> 
> I'll fix it in a little bit.

Ulgh, what was I thinking.

The reggroup code will let this be fixed properly - can finally specify 
exactly which registers should be saved/restored across an inferior 
function call.

Andrew