From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 788 invoked by alias); 27 Jun 2002 02:25:08 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 774 invoked from network); 27 Jun 2002 02:25:05 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 27 Jun 2002 02:25:05 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0C0303DD2; Wed, 26 Jun 2002 22:24:38 -0400 (EDT) Message-ID: <3D1A7765.1060708@ges.redhat.com> Date: Wed, 26 Jun 2002 19:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: tromey@redhat.com Cc: Gdb List Subject: Re: bad news about add_setshow_cmd References: <87fzz9d7oq.fsf@fleche.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00277.txt.bz2 > Today while testing my jumbo add_setshow_cmd patch, I finally came > across this code in do_setshow_command: > > /* Print doc minus "show" at start. */ > print_doc_line (gdb_stdout, c->doc + 5); Ulgh. > This isn't i18n-friendly. Really fixing it requires yet another > global change to add_setshow_cmd :-(. Also it seems like it will > require adding a new field to the command structure to hold the > translated text. > > Or, we could replace the customized text with something generic. This > is less friendly though. > > Does anybody know of other lurking problems before I go ahead and make > this change? My current plan is to go ahead and add the new field and > new doc strings everywhere. Any other ideas or preferences? Sorry, you've lost me. Which new doc string? A third string for showing the value? -- BTW, grep -e '->doc', arrhg! add_dump_command() for instance? [I think we're going to end up with GDB 6.0 due to internationalization and not multi-arch - we're going to need an excuse for changing all the output messages :-)] Andrew