From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 351 invoked by alias); 7 Jun 2002 19:55:01 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 340 invoked from network); 7 Jun 2002 19:54:59 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 7 Jun 2002 19:54:59 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9B6803E66; Fri, 7 Jun 2002 15:55:11 -0400 (EDT) Message-ID: <3D010F9F.5080304@cygnus.com> Date: Fri, 07 Jun 2002 12:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc3) Gecko/20020530 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb@sources.redhat.com Subject: Re: GDB broken on MIPS targets with unmarked binaries References: <20020605200429.GA7956@nevyn.them.org> <3CFE7825.2030001@cygnus.com> <20020605205834.GA22729@nevyn.them.org> <20020605210838.GA518@nevyn.them.org> <3CFE8596.4010401@cygnus.com> <20020607014125.GA27272@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00060.txt.bz2 > > How about setting something in each header that redefines > REGISTER_VIRTUAL_TYPE, instead? I think that's much clearer, and when > we multi-arch the targets which do this it will transition more > naturally to setting it at gdbarch_init time. gdbarch_data() is a very > nice tool, but this is the wrong kind of nail, IMO. > > I'm testing this patch. Yes, it's a little bit of a step backwards for > multi-arching, but I still think it's correct; rather than "reverse > engineer the header files to figure out the default", let's have the > header files tell us what it is. > > It works fine in my testing; OK to commit, or would you prefer a > different way? try something like: -/* Do not use "TARGET_IS_MIPS64" to test the size of floating point registers */ -#ifndef FP_REGISTER_DOUBLE -#define FP_REGISTER_DOUBLE (REGISTER_VIRTUAL_SIZE(FP0_REGNUM) == 8) -#endif #define FP_REGISTER_DOUBLE mip_fp_register-double () mips_fp_register_double () { if (current_gdbarch->tdep->fp_register_double < 0) ...->fp_register_double = REGISTER_VIRTUAL_SIZE(FP0_REGNUM) == 8; return gdbarch->tdep->fp_register_double; } And: - tdep->mips_fp_register_double = (REGISTER_VIRTUAL_SIZE (FP0_REGNUM) == 8); tdep->mips_fp_register_double = -1; It delays the computation until it is needed. It also happens to keep the old code working without having to add more macros :-) enjoy, Andrew