Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb@sources.redhat.com
Subject: Re: GDB broken on MIPS targets with unmarked binaries
Date: Wed, 05 Jun 2002 14:41:00 -0000	[thread overview]
Message-ID: <3CFE8596.4010401@cygnus.com> (raw)
In-Reply-To: <20020605210838.GA518@nevyn.them.org>

> The expansion appears to be:
>> tdep->mips_fp_register_double = (((((38) >= 38 && (38) < 38 +32) ?
>> 	builtin_type_float : ((38) == 32 ) ?
>>         builtin_type_uint32 : ((38) >= 70 && (38) <= 89) ?
>> 	builtin_type_uint32 :
>>         builtin_type_int))->main_type->length == 8);
>> 
>> I can't see any reason for it to crash; I haven't reproduced this
>> locally yet, although I'm working on it.  The above expansion came from
>> the second person to mention this to me.
> 
> 
> I believe you're right about the patch at fault, though I don't know
> what to do about it.  This makes builtin_type_int == NULL during
> evaluation of that expression, along with all the others.

The patch isn't `at fault' - it is detecting a fault in mips_tdep.c :-) 
  builtin_type_float would have contained a value from the previously 
selected ISA.

That code is trying to reverse engineer the header files to figure out 
what the default should be for the given target.

I think better would be to is set mips_fp_register_double=-1 and then 
change FP_REGISTER_DOUBLE to a real function (gdb multi-arch can now be 
assumed) that, when -1, apply the above logic (and even update the result).

enjoy,
Andrew



  reply	other threads:[~2002-06-05 21:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-05 13:08 Daniel Jacobowitz
2002-06-05 13:44 ` Andrew Cagney
2002-06-05 14:03   ` Daniel Jacobowitz
2002-06-05 14:12     ` Daniel Jacobowitz
2002-06-05 14:41       ` Andrew Cagney [this message]
2002-06-06 18:44         ` Daniel Jacobowitz
2002-06-07 12:55           ` Andrew Cagney
2002-06-07 13:07             ` Daniel Jacobowitz
2002-06-07 13:27               ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CFE8596.4010401@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=drow@mvista.com \
    --cc=gdb@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox