From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14343 invoked by alias); 17 Apr 2002 20:06:51 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 14317 invoked from network); 17 Apr 2002 20:06:49 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 17 Apr 2002 20:06:49 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6756B3D0C for ; Wed, 17 Apr 2002 16:06:58 -0400 (EDT) Message-ID: <3CBDD5E2.7000904@cygnus.com> Date: Wed, 17 Apr 2002 13:06:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb@sources.redhat.com Subject: think-o: ARM register byte ps VS fps? Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00290.txt.bz2 Hello, I'm looking at the code: static int arm_register_byte (int regnum) { if (regnum < ARM_F0_REGNUM) return regnum * INT_REGISTER_RAW_SIZE; else if (regnum < ARM_PS_REGNUM) return (NUM_GREGS * INT_REGISTER_RAW_SIZE + (regnum - ARM_F0_REGNUM) * FP_REGISTER_RAW_SIZE); else return (NUM_GREGS * INT_REGISTER_RAW_SIZE + NUM_FREGS * FP_REGISTER_RAW_SIZE + (regnum - ARM_FPS_REGNUM) * STATUS_REGISTER_SIZE); } where: #define ARM_FPS_REGNUM 24 /* floating point status register */ #define ARM_PS_REGNUM 25 /* Contains processor status */ While I suspect it ``works'', would ``(regnum < ARM_FPS_REGNUM)'' be better? enjoy, Andrew