From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: Eli Zaretskii <eliz@is.elta.co.il>, gdb@sources.redhat.com
Subject: Re: DOS/Windows-specific code: sparcl-tdep.c
Date: Thu, 10 May 2001 08:33:00 -0000
Message-id: <3AFA00EC.1000300@cygnus.com>
References: <20010503211502.21716.qmail@web6401.mail.yahoo.com> <3AF1DAA0.3060702@cygnus.com> <200105071609.TAA24129@is.elta.co.il> <200105081149.OAA06265@is.elta.co.il> <1010509064701.ZM22259@ocotillo.lan>
X-SW-Source: 2001-05/msg00209.html

> On May 8,  2:49pm, Eli Zaretskii wrote:
> 
> 
>> * sparcl-tdep.c:
>> 
>> #if (!defined(__GO32__) && !defined(_WIN32)) || defined(__CYGWIN32__)
>> #define HAVE_SOCKETS
>> #include <sys/time.h>
>> #include <sys/socket.h>
>> #include <netinet/in.h>
>> #include <netdb.h>
>> #endif
>> 
>> Looks like an Autoconf test for HAVE_SOCKETS should do here.
> 
> 
> Why not just add an autoconf test for the sys/socket.h header file and
> then do:
> 
>     #ifdef HAVE_SYS_SOCKET_H
>     #define HAVE_SOCKETS
>     #include <sys/time.h>
> #include <sys/socket.h>
> #include <netinet/in.h>
> #include <netdb.h>
> #endif

I'm actually wondering why a *-tdep.c file is even playing around with 
sockets!  Normally that code appears in *-rom.c or *-mon.c files.  One 
interesting thing, the code uses UDP so, for ser*.c to ever replace it, 
the ser*.c code would need to gain UDP support.

Anyway, Kevin's suggestion should do the trick.


	Andrew