From: Steven Johnson <sjohnson@neurizon.net>
To: gdb@sources.redhat.com
Cc: Fernando Nasser <fnasser@redhat.com>
Subject: Post Hooks Broken!!! Fix Attached.
Date: Thu, 22 Feb 2001 22:02:00 -0000 [thread overview]
Message-ID: <3A95FCCB.5D18D45E@neurizon.net> (raw)
Hi,
I Tried to use a late CVS snapshot of GDB/Insight and found my Post Hook
was broken.
It seems that it has been broken since the CLI sub-directory was
created, it was a simple problem and the patch to fix it is attached.
Defining a Post-Hook currently overwrites the standard pre command hook,
In the definition code, I had to fix the setting of the pointers to the
hook code which were erroneously setting the pre pointers instead of the
post pointers.
Steven.
Patch Follows:
diff -C2 -r -b ../gdb_cvs/src/gdb/cli/cli-script.c src/gdb/cli/cli-script.c
*** ../gdb_cvs/src/gdb/cli/cli-script.c Thu Feb 15 08:50:31 2001
--- src/gdb/cli/cli-script.c Fri Feb 23 14:55:49 2001
***************
*** 1166,1171 ****
break;
case CMD_POST_HOOK:
! hookc->hook_pre = newc; /* Target gets hooked. */
! newc->hookee_pre = hookc; /* We are marked as hooking target cmd. */
break;
default:
--- 1166,1171 ----
break;
case CMD_POST_HOOK:
! hookc->hook_post = newc; /* Target gets hooked. */
! newc->hookee_post = hookc; /* We are marked as hooking target cmd. */
break;
default:
next reply other threads:[~2001-02-22 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-22 22:02 Steven Johnson [this message]
2001-02-23 5:45 ` Fernando Nasser
2001-02-25 21:11 ` Steven Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A95FCCB.5D18D45E@neurizon.net \
--to=sjohnson@neurizon.net \
--cc=fnasser@redhat.com \
--cc=gdb@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox