From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: gdb@cygnus.com Subject: Re: More gdb-4.17.85 testresults Date: Thu, 01 Apr 1999 00:00:00 -0000 Message-id: <36E86522.722EFB9B@cygnus.com> References: <9903039205.AA920520366.cygnus.gdb@cc.pmsc.com> X-SW-Source: 1999-q1/msg00114.html Jim Blandy wrote: > Based on the responses from the ANSI C wonks, I think you're going to > have to change the argument types in the prototypes. Glancing over > it, this doesn't look like a problem. Below is a somewhat pragmatic patch to address the problem (assuming that this weeks mailer doesn't eat several long lines :-). The thing is that the function remote_query() is assigned to `struct target_ops'.to_query. If we're going to change the signature of remote_query() then we'll also need to change to_query and any other uses of it. (While there are not that many it does appear to be excessive effort for a problem that goes away in the next release). I figure it is easier, for the 4.18 release, to just zap prototypes when they create problems. The below is for your aproval. Andrew *** remote.c 1999/03/10 03:27:15 1.179 --- remote.c 1999/03/12 00:46:39 *************** static int ishex PARAMS ((int ch, int *v *** 294,301 **** static int stubhex PARAMS ((int ch)); - static int remote_query PARAMS ((char, char *, char *, int *)); - static int hexnumstr PARAMS ((char *, ULONGEST)); static CORE_ADDR remote_address_masked PARAMS ((CORE_ADDR)); --- 294,299 ---- *************** char *unpack_varlen_hex PARAMS ((char *b *** 315,322 **** static char *unpack_nibble PARAMS ((char *buf, int *val)); static char *pack_nibble PARAMS ((char *buf, int nibble)); - - static char *pack_hex_byte PARAMS ((char *pkt, unsigned char byte)); static char *unpack_byte PARAMS ((char *buf, int *value)); --- 313,318 ----