From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16883 invoked by alias); 24 Jun 2011 09:38:29 -0000 Received: (qmail 16874 invoked by uid 22791); 24 Jun 2011 09:38:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Jun 2011 09:38:14 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id CE92BCB03A6; Fri, 24 Jun 2011 11:38:12 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fb3vAykwthHk; Fri, 24 Jun 2011 11:38:09 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id C44F0CB03A2; Fri, 24 Jun 2011 11:38:09 +0200 (CEST) Subject: Re: patches for mac support Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: <9B2A7195-51A9-4F40-97B9-159E041D3174@nokia.com> Date: Fri, 24 Jun 2011 09:38:00 -0000 Cc: gdb@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <3634A65E-25ED-4F1F-8D22-AD3FCEAF2C9B@adacore.com> References: <9B2A7195-51A9-4F40-97B9-159E041D3174@nokia.com> To: Fawzi Mohamed X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00138.txt.bz2 On Jun 23, 2011, at 10:07 PM, Fawzi Mohamed wrote: Mohamed, First, thank you for this work. > I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=3D114= 88 . > Now I think that I have reached to bottom of it, and I have a set of clea= n patches that could use a review. >=20 > Apple gdb simply ignores the eh_frame sections for the libraries without = embedded dwarf info, not using eh information (which was the first patch th= at I submitted) but I find that one should be able to use them, so I looked= further and found the "correct" fix. > As the path to it was a bit convoluted I have done a few improvements to = pieces of code that did fail as consequence of the original bug. >=20 > The "main" fix is > http://sourceware.org/bugzilla/attachment.cgi?id=3D5816&action=3Ddiff > which fixes the mmaped read of sections. We (AdaCore) has something very similar in our internal tree. I very recen= tly worked on submitting a patch to fix this issue. The submitted patch was larger as I tried to clean-up this API. Note that you need to properly submit your patches: one patch by mail is be= tter (IMHO), patch should be inlined if not large, and you need ChangeLog entries. I suppose the instructions are on the web, als= o I don't know where. > I feel that > http://sourceware.org/bugzilla/attachment.cgi?id=3D5817 > which adds a check on the cie pointer is important and improves gdb robus= tness and should also go in. >=20 > http://sourceware.org/bugzilla/attachment.cgi?id=3D5814 > adds the forgotten ignore of routine_64 load command, and should also go = in Note that this should be submitted on the binutils mailing list. > http://sourceware.org/bugzilla/attachment.cgi?id=3D5809 > is something that I have seen apple does and seems reasonable, but I have= not needed it, so I am not sure if it should go in >=20 > I have also noted that compiling gdb I have the following conflict in the= grammar, not sure if you are aware of it >=20 > /bin/sh ../../gdb72/gdb/../ylwrap ../../gdb72/gdb/m2-exp.y y.tab.c m2-exp= .c.tmp -- bison -y > conflicts: 34 shift/reduce > /Users/fawzi/dev/gdb/gdb72Build/gdb/../../gdb72/gdb/m2-exp.y:355.25-44: w= arning: rule never reduced because of conflicts: @2: /* empty */ Tristan.