From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81895 invoked by alias); 21 Sep 2017 17:56:10 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 81850 invoked by uid 89); 21 Sep 2017 17:56:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:c713fc7, H*i:sk:c713fc7, personal, invested X-Spam-User: qpsmtpd, 3 recipients X-HELO: mail-wm0-f43.google.com Received: from mail-wm0-f43.google.com (HELO mail-wm0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 17:56:07 +0000 Received: by mail-wm0-f43.google.com with SMTP id b195so4032317wmb.5; Thu, 21 Sep 2017 10:56:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:from:message-id; bh=/95Y43ddJyAPeb/fM0Va+ieFmdG8Ccj4rjVhhiiAjME=; b=YIhFIgNOKXVDxp6oN3Df99983UQQMMycs4ehrPmebGG3w2h8UyRpdHAJco+uNgkgba QvAGKijkhTR5YScI3v0+PnbVd0slpIPFvJcURJW0MVmL9EXKx6VOwFlKlGeCU+crR+pT LI2+EyrrvH46Wylu+iSWDo8JWMVXKEI05kckd2AGiU5zxcUFV+RAggFmOoWzBP99wrnp 6KxU2neCm/m2UVoRFy/gcHyWbsf+IHROj+YPG8AmnmTG9UyEgP/dbkfBz79/62PLcbyk CcNbYcnOxYn81H+6KYfq+fBonDEe4Fq4WcTgQUSo+deIhACZ7OfQSTzIGWziB7vMN8tQ RBYg== X-Gm-Message-State: AHPjjUjhJiQ3gwRrebMhazEOjNWuLmDVqX6iUNposEgb98LrG9g/bYXb V3nERvIL+dzsUCQdv3xNix1OBOE5 X-Google-Smtp-Source: AOwi7QCABS3/3s24agF0oXfbX1LPE1owI9rmNeViau7oXE38IbN9ANewExfME8l1u5/1urJl3ONYGQ== X-Received: by 10.80.240.67 with SMTP id u3mr2082248edl.35.1506016565801; Thu, 21 Sep 2017 10:56:05 -0700 (PDT) Received: from android-97b5c0ce9bfced28.fritz.box (p5494E583.dip0.t-ipconnect.de. [84.148.229.131]) by smtp.gmail.com with ESMTPSA id x10sm810280edb.24.2017.09.21.10.56.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 10:56:05 -0700 (PDT) Date: Thu, 21 Sep 2017 17:56:00 -0000 User-Agent: K-9 Mail for Android In-Reply-To: References: <87zi9oj8rl.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: GNU Tools Cauldron 2017 follow up: "Reviewed-by" etc. To: gcc@gcc.gnu.org,Carlos O'Donell ,Thomas Schwinge ,gdb@sourceware.org,binutils@sourceware.org,libc-alpha@sourceware.org From: Richard Biener Message-ID: <347AE883-971C-447C-AB07-43F7F70F25D3@gmail.com> X-SW-Source: 2017-09/txt/msg00093.txt.bz2 On September 21, 2017 7:38:29 PM GMT+02:00, Carlos O'Donell wrote: >On 09/21/2017 10:50 AM, Thomas Schwinge wrote: >> So my question is, if I've gotten a patch reviewed by someone who is >not >> yet ;-) familiar with that new process, and I nevertheless want to >> acknowledge their time invested in review by putting "Reviewed-by" >into >> the commit log, is it fine to do that if the reviewer just answered >with >> "OK" (or similar) instead of an explicit "Reviewed-by: NAME " >> statement? >You should instead ask the author to give their "Reviewed-by:" and >point >out what the Reviewed-by statement means. > >> That is, is it fine to assume that our current patch review's >standard >> "OK" (or similar) answer matches the more formal "Reviewer's >statement of >> oversight"? > >Not yet. I think given an OK from an official reviewer entitles you to commit it ind= eed IS matching the formal statement. It better does...=20 >> Maybe in the future, reviewers will then switch over to explicitly >> stating "Reviewed-by: NAME " -- or maybe not, because "OK" is >just >> so much easier to type... >All of this is nothing compared to the work of doing the review. Depends on the complexity of the patch...=20 Richard.=20 >It will be your own personal comments, your reminder, your leading by=20 >example, that will change behaviours.