Re: memory region documentation

["Eli Zaretskii" <eliz@is.elta.co.il>]

> From: jtc@redback.com (J.T. Conklin)
> Date: 30 Nov 2000 12:08:53 -0800
> 
> The reason I didn't think it fit in the Data chapter was the not yet
> implemented breakpoint attribute.  GDB needs to insert breakpoints for
> step, next, continue, etc.; but it can't do it if the memory region is
> protected (ie, image is running out of ROM, FLASH, etc.).  So there 
> needs to be a mechanism to tell GDB to use hardware breakpoints for
> those internal breakpoints.  This part of the feature isn't really
> "data" related.

That's true, but I don't think this is a reason grave enough to make
this a separate chapter.

I think the right question is: would a user reasonably expect this
feature be described under Data?  If so, we can put it there.  We can
also add a short explanation in the section about breakpoints saying
that in the case of read-only code memory, they need to use memory
regions first, with a cross-reference to the stuff you've written.
From rth@redhat.com Thu Nov 30 23:26:00 2000
From: Richard Henderson <rth@redhat.com>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: Daniel Berlin <dberlin@redhat.com>, gdb@sources.redhat.com
Subject: Re: [crash] Section index is uninitialized
Date: Thu, 30 Nov 2000 23:26:00 -0000
Message-id: <20001130232605.A7627@redhat.com>
References: <20001130174058.A16314@redhat.com> <m3wvdk21xf.fsf@dan2.cygnus.com> <dberlin@redhat.com> <1001201054052.ZM7363@ocotillo.lan>
X-SW-Source: 2000-11/msg00290.html
Content-length: 540

On Thu, Nov 30, 2000 at 10:40:52PM -0700, Kevin Buettner wrote:
> The call to fixup_symbol_section() (which is one line before the line
> indicated above) should be setting section to the section associated
> with the minimal symbol.  I think we need to find out why
> fixup_symbol_section() is failing to do this.

Turns out to be more convoluted than that.  fixup_symbol_section
is setting the section to that of the minimal symbol.  It's just
that that is -1 as well.

More pointers?  Or, if you like, ~rth/gdb-killer in Sunnyvale.


r~
From kevinb@cygnus.com Fri Dec 01 00:51:00 2000
From: Kevin Buettner <kevinb@cygnus.com>
To: Richard Henderson <rth@redhat.com>
Cc: Daniel Berlin <dberlin@redhat.com>, gdb@sources.redhat.com
Subject: Re: [crash] Section index is uninitialized
Date: Fri, 01 Dec 2000 00:51:00 -0000
Message-id: <1001201085134.ZM28276@ocotillo.lan>
References: <20001130174058.A16314@redhat.com> <m3wvdk21xf.fsf@dan2.cygnus.com> <dberlin@redhat.com> <1001201054052.ZM7363@ocotillo.lan> <20001130232605.A7627@redhat.com> <rth@redhat.com>
X-SW-Source: 2000-12/msg00000.html
Content-length: 1996

On Nov 30, 11:26pm, Richard Henderson wrote:

> On Thu, Nov 30, 2000 at 10:40:52PM -0700, Kevin Buettner wrote:
> > The call to fixup_symbol_section() (which is one line before the line
> > indicated above) should be setting section to the section associated
> > with the minimal symbol.  I think we need to find out why
> > fixup_symbol_section() is failing to do this.
> 
> Turns out to be more convoluted than that.  fixup_symbol_section
> is setting the section to that of the minimal symbol.  It's just
> that that is -1 as well.
> 
> More pointers?  Or, if you like, ~rth/gdb-killer in Sunnyvale.

Try the following patch...

	* elfread.c (record_minimal_symbol_and_info): Don't guess
	at the section index to use; just use bfd's index.

Index: elfread.c
===================================================================
RCS file: /cvs/src/src/gdb/elfread.c,v
retrieving revision 1.11
diff -u -p -r1.11 elfread.c
--- elfread.c	2000/08/07 15:02:48	1.11
+++ elfread.c	2000/12/01 08:45:34
@@ -171,32 +171,13 @@ record_minimal_symbol_and_info (char *na
 				enum minimal_symbol_type ms_type, char *info,	/* FIXME, is this really char *? */
 				asection *bfd_section, struct objfile *objfile)
 {
-  int section;
-
-  /* Guess the section from the type.  This is likely to be wrong in
-     some cases.  */
-  switch (ms_type)
-    {
-    case mst_text:
-    case mst_file_text:
-      section = bfd_section->index;
 #ifdef SMASH_TEXT_ADDRESS
-      SMASH_TEXT_ADDRESS (address);
+  if (ms_type == mst_text || ms_type == mst_file_text)
+    SMASH_TEXT_ADDRESS (address);
 #endif
-      break;
-    case mst_data:
-    case mst_file_data:
-    case mst_bss:
-    case mst_file_bss:
-      section = bfd_section->index;
-      break;
-    default:
-      section = -1;
-      break;
-    }
 
   return prim_record_minimal_symbol_and_info
-    (name, address, ms_type, info, section, bfd_section, objfile);
+    (name, address, ms_type, info, bfd_section->index, bfd_section, objfile);
 }
 
 /*