From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-return-26958-listarch-gdb=sources.redhat.com@sourceware.org>
Received: (qmail 19927 invoked by alias); 28 Nov 2006 19:51:24 -0000
Received: (qmail 19914 invoked by uid 22791); 28 Nov 2006 19:51:23 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-vbr4.xs4all.nl (HELO smtp-vbr4.xs4all.nl) (194.109.24.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Nov 2006 19:51:15 +0000
Received: from webmail.xs4all.nl (dovemail1.xs4all.nl [194.109.26.3]) 	by smtp-vbr4.xs4all.nl (8.13.8/8.13.8) with ESMTP id kASJp0Tb010263; 	Tue, 28 Nov 2006 20:51:01 +0100 (CET) 	(envelope-from mark.kettenis@xs4all.nl)
Received: from 193.137.208.250         (SquirrelMail authenticated user sibelius)         by webmail.xs4all.nl with HTTP;         Tue, 28 Nov 2006 20:51:02 +0100 (CET)
Message-ID: <23359.193.137.208.250.1164743462.squirrel@webmail.xs4all.nl>
In-Reply-To: <m3slg3tmyh.fsf@codesourcery.com>
References: <456B8B19.8050403@mvista.com> <m3slg3tmyh.fsf@codesourcery.com>
Date: Tue, 28 Nov 2006 19:51:00 -0000
Subject: Re: [PATCH]: Clarify the warning displayed when you debug a core       file  for the wrong architecture.
From: "Mark Kettenis" <mark.kettenis@xs4all.nl>
To: "Jim Blandy" <jimb@codesourcery.com>
Cc: "Nitin Gupta" <ngupta@mvista.com>, gdb@sourceware.org
User-Agent: SquirrelMail/1.4.8
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Mailing-List: contact gdb-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb.sourceware.org>
List-Subscribe: <mailto:gdb-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb/>
List-Post: <mailto:gdb@sourceware.org>
List-Help: <mailto:gdb-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00203.txt.bz2

>
>  Nitin Gupta <ngupta@mvista.com> writes:
> > Pushing one of the old patches from Daniel into FSF.
> >
> > 2002-08-30  Daniel Jacobowitz  <drow@mvista.com>
> >
> >        * corelow.c (get_core_register_section): Clarify warning.
> >
> > Index: gdb-6.3.90_20051109/gdb/corelow.c
> > ===================================================================
> > --- gdb-6.3.90_20051109.orig/gdb/corelow.c      2005-07-04
> > 13:29:10.000000000 +0000
> > +++ gdb-6.3.90_20051109/gdb/corelow.c   2005-11-09 23:23:54.000000000
> > +0000
> > @@ -462,7 +462,10 @@
> >   if (! section)
> >     {
> >       if (required)
> > +      {
> >        warning (_("Couldn't find %s registers in core file."),
> > human_name);
> > +       warning (_("Core file may be for a different architecture.\n"));
> > +      }
> >       return;
> >     }
>
>  I don't object to this patch, but I wonder if there isn't a better
>  place to do the check, where we could issue a more informative
>  message.
>
>  Does this warning ever come about when the core file is *not* of a
>  different architecture?  I'd assume not, since the caller indicated
>  that the section in question is required.
>
>  (Sorry if this patch has been discussed before --- I couldn't find the
>  thread in the archives.)

I don't like the change.  It's replacing a factual statement with a
specualtion.