From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cBcdECk0jmfhWRUAWB0awg (envelope-from ) for ; Mon, 20 Jan 2025 06:31:53 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=uLEq8B6O; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3E6411E100; Mon, 20 Jan 2025 06:31:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 50E3C1E08E for ; Mon, 20 Jan 2025 06:31:52 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8BDA13857C5D for ; Mon, 20 Jan 2025 11:31:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8BDA13857C5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1737372711; bh=7nEwPdx9zTAmxZDdinmZ6hKV7CF0a7KCNioBe7NbNr8=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=uLEq8B6O56wlZ6qS3gp3kYdH8DBcNxQY7R5eDbh/gTRSaKwe+xd6IHYcq6XwfuvVl ry3BPwaQIbFcLqbfbfHj4qVGueNx6DSAy0HNSf9nfiZb/edEXANbg0NAMZDoSReIaX KyZ/DVslWv9TwUglDTJOANYKBaAWOBz01BK/qH54= Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170110001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::1]) by sourceware.org (Postfix) with ESMTPS id D2072385843D for ; Mon, 20 Jan 2025 11:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D2072385843D ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D2072385843D ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1737372663; cv=pass; b=c8wfG86hcD6irz5PbdxMZJD8Jnz0XERGUs5W4v7Y8fAtmqTHd6oOqTPVtg4PSTbZWm9Ku6qXnGeXwktKE2zMmjx/F3xHftxhiUhtzT6FOsgcUoJlIx4ozXp37EKZGHTH680AZWaMMqFCj/0tife/u6LAVq2qK6CCk3TSgWLttN8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1737372663; c=relaxed/simple; bh=jt0ZU/wk9VpsB1cckG8ymLJkSD7GlzRpr9ZyGyC4BWU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=HD9rG+rjrYhbfa+3jK42l+JepwIUitiWfOv4PWL4az3ZCW+2UYT/fTNLieijaBw3p7I0FInhefLT6DE57MbIFbFWe5QjPcQgnklXHqNuy5WizS9XVhuEHQbsRKOd89cXHKXtwekifkNvYFPTtUr6tD/tChSKg76IGnMZEXfnpHU= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2072385843D ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dcdzy6xZeO5p83PrjZWIt1VOZuBRdN4G93lKW/4AujG63ljHM5LnfIOPw8wM3n45dTUtEFoPY23bXhmjqjk3xLi0Y9MxPrxzvH7q4Y/8TpRgTQzBDH9+pFZ8XsZHmMFzmn8ryzeHr+jRQwA2jEFPOeiU6PxTF7Kmmjfm6M5C84MggS8fw6NDGz8UrAEV+H4hwK70Jia8P26VXs3iDn9zsfzi96vn4W9F/fyzclIrVrgnc8LNSICw+0kItgibO82YKwaDeK3rzySuJ9ORZv4RjFPvzR957+kiGWD8T7ekTaaxwJwrHss4tTrc/a/AiEdwBGYPAUbr9Vv/8ic84DHZag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7nEwPdx9zTAmxZDdinmZ6hKV7CF0a7KCNioBe7NbNr8=; b=GvOkKn30nIC3AlLBnYlQU9AGgQcZtae+2LuGnAG3jiPm2Bk4Pa+c3mnzefMZnj1iN0UI/RGNq88pYAE/+Fywy2vtP+CUIOe4nEffUE/lR8gkndvR4vSpOEzXkbyIOoNli5rOScdJP8DSPXFgmUtHJpnkGzv2o5eSXdIFNK50lOz1qO3PZ0IUG6Q4dbuvDFnGUgupz2pRc928tOnaCaVcDhuHB+pGc0RsyOehG74MRYlMHfqOUNl0fPjJ4HUdg0Bsa3ksN3CwR9VZCOuuIxLofAteiisIJwJ/Nz7TZBLdSuZFejWfkgH6BszhwI0P5MYv9YXXfZB5EFg0Oa1yIJM2Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by DBBPR08MB10556.eurprd08.prod.outlook.com (2603:10a6:10:531::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Mon, 20 Jan 2025 11:31:00 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%4]) with mapi id 15.20.8356.017; Mon, 20 Jan 2025 11:31:00 +0000 Message-ID: <2270275a-98e3-4581-82a9-85339b94ae5d@arm.com> Date: Mon, 20 Jan 2025 11:30:59 +0000 User-Agent: Mozilla Thunderbird Subject: Re: automated coding style tool Content-Language: en-US To: Tom Tromey Cc: Simon Marchi , gdb@sourceware.org, "Aktemur, Tankut Baris" References: <86538dac-6c3a-4b9e-9de9-3906e645fa4d@redhat.com> <87y16vwbzl.fsf@tromey.com> <74c8b867-f5bb-48f7-9849-11d06e63a3d7@arm.com> <87tta2r5z2.fsf@redhat.com> <87tta1qq1i.fsf@tromey.com> <2985f4ae-33c0-4e02-8982-fa132f4d3741@simark.ca> <87msftuhd3.fsf@tromey.com> <87v7uct0h5.fsf@tromey.com> In-Reply-To: <87v7uct0h5.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0149.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::13) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|DBBPR08MB10556:EE_ X-MS-Office365-Filtering-Correlation-Id: 675fa1f7-2e6b-4ad5-1f4a-08dd3945ea19 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dFluVXBrZitWd0FscXVaWlA0MlNMSTF3TVB1b2ZtMXM5TFdRcDExeUFaVEc0?= =?utf-8?B?NFkzZzlLdWNiVUlkVi9uNEZlaWtFM1RxVWR0OEErTGthckJPcnA4bTRCU3JC?= =?utf-8?B?cCtZdFN6UjN6OWlBaHBBckxNSDh1MUF6SDNjdnJzMFYwK2xsUUI0UWFReTVL?= =?utf-8?B?UWRpYWZZbjR0S1V2SkZsREh1OVZFeGJJR3NnVThCOWRhM2doUEE0ajFZV3RP?= =?utf-8?B?bzczS1JROVFEazdSTW9uQ01TL3dSODgzVkRQdnhVMXRyb3pscXVEaitDOHAr?= =?utf-8?B?L3hURzNiSjNJZUJ0dm5mSnFBYjZzUkpsMTZkMWdBSEU2NUJYNkRub1l6Qy82?= =?utf-8?B?VnUydW8vNXJqL3pnUkJydFFoVnpQUUdsOHArUjZGc2hscEdLbE9MbDZib0VN?= =?utf-8?B?RENnWWc4aXNLVDJKNlNGYWN0OVZOYXdmRHdvSUFEaGtEbU5jN2owWE10TEtl?= =?utf-8?B?RHhjMWRnVzNsR1lmZnZ0YXBKek5yN2NZSjhmTi9QYlpRaG9ZaC9hcjVrQXEz?= =?utf-8?B?OHRnUVBtUDdLeW1MTTRvRFM4NHYvZTFaNDY2N0JvOWY0ZElVUXR4ajlYeXBT?= =?utf-8?B?RVk5blVCbHpmYnhhYTdFQktiSlRKRlVWQ1kwS1M0NzZIamRiazBZRkJSNlJ6?= =?utf-8?B?TGJTOVVCZ1FSY2tHenEvY251ckZnM0tvOURITEJ1dUpQZGRBZmQwb1RTMVJn?= =?utf-8?B?dlJxcWlUVVp1dTJkNHVwZkJxYjNRKzF0aXVCTEo0bHdjL2wxZlpPWEtJcndC?= =?utf-8?B?M3AzZmFVcU9LL05yQ3pQaC9TTDltdjJ2MmFKZmtsdzZaUCtKTWJseC9QeSt5?= =?utf-8?B?MVVyekRrTWhiZVcreHVaOVdKYWtxWmJEZFNGVU11QVlGcmlBZVdQWTBqUkph?= =?utf-8?B?MUx3dnVHb2RSVlA0YkU4bldGQlpKc1NxTVAzbFNETkRVWDUxN3BLSUJCVkNw?= =?utf-8?B?V2xsSTFDV1daS0wrUTk3UHA4QzB5VW1VVVROS2gvMTMwRzFUemVNN3FTazg5?= =?utf-8?B?RStSVVRJbnd1MUMrQVlPclNjTzhJS2VZeDA0ZG0yNkpCSTJPVFJmcHc2Z1hV?= =?utf-8?B?TVpqQnA3VG5abFI4VHNsbW90bG9laUN4RitjUDBWazNsM09DS2dlaFFUaUVs?= =?utf-8?B?QXpVTVlNSEJGSHpTbzhEOXlnZy9KVXVWU0dSS0h0VTAycmp0WG85eHEwVE5C?= =?utf-8?B?RFE0a0NaanRVSm1YbWY2cERwRkc1dlhubDRJZ3hOdGozZjJrWlhUTWIyRS9B?= =?utf-8?B?QU1FdGVzQ1BPd3BHMzArcHpzcjhyRWRadXBaSTV3RURrdkRYRmtuYVpwaWlY?= =?utf-8?B?MWMydDNrR2NSMWFsMkVSWnN0NzU4blFGRUFRanJMRy9YZHowL2ZYSE9hMDBw?= =?utf-8?B?QWFwc1JRU2I4RkdDSmJoYmlFRlQ3c0NFUG84c3RmTGdCZ0xyRlFXTTFaREMy?= =?utf-8?B?dDlqK2JDQzB5VlFOTzZjS1NlV1lTZ24yZ0htWWozczVxblN5clROYXlKN2Z3?= =?utf-8?B?NGRyT01DVm9VZHUyZnJYQkpweGcxU0tWOE0rUjIvTEhIZ0ZUZEEzbTBJTEtv?= =?utf-8?B?U1hZMHV2WVJ1YytiL1MydnlDZkpmTW9nNEc5TllJcm1yWDFITXF5bmhySGlW?= =?utf-8?B?dzZnbCtWL0I1dVJDdlFmclo3MkRvcGthZ1AveUJ2M0V1TEpscTNIbkRGOS9F?= =?utf-8?B?aktyYUhZL0lhdXJyMXVJOWFjUjNZajVsbFIxeHkxYzB1aS9uSzk4Znk4ZDJa?= =?utf-8?B?YnNkbitPMjNFSkM0ZS8zUFdGSUg0OWh1eW94WTRtUXE0eXRLU0xZV1RVcVJ6?= =?utf-8?B?blc5bTlHYnVKbFg2N2VPYWFLTkg0UnhTWnRoNXBoTHcwZTFPbFE0V2hhNlRj?= =?utf-8?Q?6HOgYSLtYmuOs?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEREU0xkMGY1RytGTmFGOVhTejM3dUEvdFlOdGxLUEZmbllZT21jT244YUhl?= =?utf-8?B?cTdjT29NbERaU241WlNWd29Na3dEOEZLVWFMSFI3VzlEQUNaOTZvcWhBaTZw?= =?utf-8?B?ekdlcEwwck55VUVwUCtUR1Y5S1hGbnZDbjVuWGVvT3dMZ2VNamQ0WTNjb1lT?= =?utf-8?B?bW5qYjJUWGdHV3RzU3ljRlhMQ2JvVC9mM29IMVZZRUNPK1NWaFRraGtVMnZv?= =?utf-8?B?cDZXV01xTmFtT3JwY0k1eFZmd2s0cWRoVVJRTFNBeFBvbnZPT0xkN1UxUWRP?= =?utf-8?B?K1RRdTlQOVhZclhHNVZKMElaUWV1YStSbndRV3lDb1lPdXJ4c2kwWk5pbVhv?= =?utf-8?B?S0w0MGtVMGVwcnhqczFRN0FFdWE2M1RBSTFpVWlibE1pTE96QXVNSll3NGV4?= =?utf-8?B?dUVLSzZyN0V4VVpCK2VBNnBpbWpBMWUrNDk2NDBqdHAvWWt6dFhoSWtuYWVq?= =?utf-8?B?V2ZISUJ3cm5OQmZOeVNjNVhZT2pmbE10VVFDSEN3dVRibFpXRlR1aUc1Yjhn?= =?utf-8?B?MXhncmZmalhNbjl5dmFtaEUyMCthdXl3eldnMXo0NzkreHN6OVUydlphNGky?= =?utf-8?B?em5wMzk2cW4rYkdKRkg0Qms1bWNIWHdYOGlMVEdQNk5SYTFiWVVIbDJiZzJv?= =?utf-8?B?d3crVElNUXVaRXR4V0gwOG52dEJzT1lVUnJKZy85NXBYaTdFbCtpRjIvZUc4?= =?utf-8?B?Y21WZEl6bG9neW55bTAzcDRLOG8yN216MEQ0OWJ2WnNSOU00ZDBtMHN4SUt4?= =?utf-8?B?ai9tSmNoV0xjSUVxb3RrQ2tjSElBSnpRcWd2MXJzVFBDcWttUStBa2lDUUNF?= =?utf-8?B?azFDVjgzNUFaeTdWbDB1VkJwUitTaWVKSGFMUUVxby9jMXB6djNkWmdtaFNE?= =?utf-8?B?T1FQV1RNY2JycDlmVFg5RzNZNzFRT3VndWQvcXpZK0o4THg0RTNlOE10MG9K?= =?utf-8?B?bzRMSzNkZURZekM4bVkrWXZxR0pvMERIWllQZzJnT3FoUWRqa1kzNW5Pd1cy?= =?utf-8?B?SU4vUHB2MnFNNHJPWEhiSFFaaVYvTzJZZm8rdU9iU2MzOWR3MTlaTGRjYXBD?= =?utf-8?B?ZTFyNlA0RGVSRWxGcW05UjJVWVo3N3MwMUdqWDVZeHV2dUREbDhBakRZUHNq?= =?utf-8?B?dkFRM3BJeXg1bUwvNDNQM0hJNWF1aGlURkU0WXQ2V2NXMjd1RmxyVTc4WmpC?= =?utf-8?B?S0ViS1RJZit5MGp0ZlNPZk04Q0VNU2FnNGViOEFGbUF3VzB1Yi9oR00wbzY4?= =?utf-8?B?NlJjcWJ2WTNLdHZkdmNDMURySGxUakFDOGNKbTMvOFBEcm9aU2FaQzdmYnhw?= =?utf-8?B?bklWSE9tOW0xNm56TmRVNU1SR2pndUtaUzdUdzArVDBmbCt2ZGg2WXo1M3FI?= =?utf-8?B?SEI0cWYxb0M4MHk5dXpHcGZxM2xxWXFMSUFaOW1VUEYwWjU1elhJR2orSjND?= =?utf-8?B?cTZrVWk4NkFWRTFvdTNneitvWWNLYlhWQkVPckFNVUtZeHVzdHVWK0k0M245?= =?utf-8?B?K0VENklZTnlaRGU1RDFhVERLeE4xNFc5bG1DWnpYbW0zZUZ0SStZYXZYd3l1?= =?utf-8?B?U3hVYXdSblNHNWVlUlAyeGpOWVkrbkphQkFhRXpyR2hiOE44bE9XL2NFNzJL?= =?utf-8?B?anRBSUMyUTdkQng4Y1BGaFJNd3ZYbEhoTUxuQi9sRmVvWUFvaEIyRlY5MFpr?= =?utf-8?B?d3V4SGpGeG1OSHZoNmZ4aEhPMWJlOGx6dlptSW5UWUNQMlg4Yk5tK0ZzcDY4?= =?utf-8?B?azZjblNMSkdza1JDQ3hueUFvTGM4MW5qbDR1K2tBRWdBUXV6UHhwWWx2UG85?= =?utf-8?B?MTRKUEtkQUxUTnlMeGFoU2MyWHZLNDViWnRQakVISC85SnRkbm1hK2p2OWtB?= =?utf-8?B?VXpheGhaeGR1NFBvV2NyWFJpZEJqek4wZEg4c3dwMjdIeVZuNGZWVVQ5aHVy?= =?utf-8?B?ZE9zZEZmdkhkVnRZcldsbC9McndKQnZPUWxhNGVSMmpZaC8rYXFRcXlLdmh5?= =?utf-8?B?ZENnQWxvelJ0RStPajRzaTAxajVPajNxMW5oWGJMTEllQm81U2VTNWRyemor?= =?utf-8?B?MFQyMGc0ajUwczFnZTQ3R3c0VUFTUU1LNlE4Uk5PcnpFZGEyS0wzcEtmTTY1?= =?utf-8?Q?LpPik/MBp9l6qd1Tb6bSOFH8L?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 675fa1f7-2e6b-4ad5-1f4a-08dd3945ea19 X-MS-Exchange-CrossTenant-AuthSource: PR3PR08MB5852.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 11:31:00.0971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WhIy+1ZCTTteQgUY974nArd7ruIaXr9DYuQoDKXis9mmUv4dTXMe9oiosagc7+uLG9/76zk9/+40Vj8youuZlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10556 X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb Reply-To: Luis Machado Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" On 1/18/25 18:56, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > >>> I'm in favor of using a tool but my view is that it has to meet some >>> minimal standard of usefulness. I just think clang-format does not do >>> this. > > Luis> That's fair. But are we factoring in the amount of time spent over the years > Luis> telling contributors "you forgot a space here", "two spaces after period"? > > Yes, of course I did. Sorry, it was more a rhetorical question. I wasn't implying you had not. > > I review a lot of patches. My feeling is that formatting is > occasionally an issue, particularly with newcomers, but not really a big > part of review. Bad formatting can be a signal that a patch requires > more attention, because experienced developers try to make their changes > conform to the style of the surrounding code -- so discrepancies mean > you may be dealing with someone who isn't so adept. > > On the other hand, I also read a lot of code. And, my view overall is > that readability is far more important than ease of formatting. And, > furthermore, I dislike some aspects of clang-format's output, on > readability grounds. I think readability is important as well. My personal take on it is that formatting might make less of a difference compared to how the code is actually written. In particular excessive templating, lambda's, macros and excessive use of auto are things that tend to bring readability down for me. But they tidy up the code somewhat, so it is a compromise I guess. > > Luis> Some stuff is a bit different and some other stuff is very different. But > Luis> personally I'm willing to see this automation go through and I'm fine > Luis> adapting to a potentially new format, whatever that is. > > Me too, but within some bounds. > > Luis> I might've mentioned this already, but for folks that deal with > Luis> multiple projects, > > FWIW I also deal with multiple projects. I'm aware of that. I think it came out a bit off, but I wasn't implying you didn't. Sorry if that sounded like that. > > Tom