From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ySxmBK8JemrRPBsAWB0awg (envelope-from ) for ; Mon, 10 Aug 2026 13:26:07 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=J2B3B6B/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 06B161E166; Mon, 10 Aug 2026 13:26:07 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3B8F21E09B for ; Mon, 10 Aug 2026 13:26:06 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C6C184BB1C0B for ; Mon, 10 Aug 2026 17:26:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C6C184BB1C0B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1786382765; bh=iXifpYbsIH5Hzlm+q7BDwAVxN2XRZKSdd6s2RfEIrss=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=J2B3B6B/D7kO11HHfJUCJwUus4RxIXTna2e+n+bViT02iK4CYgAi2wnVP6QvybSKo geO4l9FEUYftYQyPeZAoyLTZsd1RbC9ZBuDojlPirB1QU8N2tFK/+UxzXHxp0hWNKU skBA16pKR0CQrfoBxYwQWCTlmkWa3HijLlYuCfjc= Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id B50494BAE7F6 for ; Mon, 10 Aug 2026 17:25:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B50494BAE7F6 ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B50494BAE7F6 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786382731; cv=none; b=GjXROWZez6v052gSI4PfJwcDU8MYieCHllDMcSJ7Esb7Yp3VPxnrvBlji5DjzQT4JVCx7mqE0iGnzHFIRWs51dLjSWINQlbkW2uKbmWuwAifDMicmy40d0awDa3EWfqwmLqiQOHOYuePBBEYHfPISYQmHHdaT/CGYD5LbrUKar8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786382731; c=relaxed/simple; bh=OEX2PmLXmIC6lYDxO2mF90aNk/AwDZHGP6HMaXKjr3g=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LR8RIbqdF12wlzc0CHog32ewQw/wvwVizq5xCcf6xowDmDMjWkKYhdi5AZ3BVbM8wQ0ziT7vrw0wA39sJt3L8MlEKvLE8xYqKw34MODGbkoDeTAG1aZoBkBUfYhPtWqfgjqds9VO/1bNX6CgBb+GM8zZT5u8fq0/ajzyTY8wc74= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=tenstorrent.com header.i=@tenstorrent.com header.a=rsa-sha256 header.s=google header.b=TIUNQbLj DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B50494BAE7F6 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-84847482584so98046b3a.0 for ; Mon, 10 Aug 2026 10:25:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786382730; x=1786987530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=iXifpYbsIH5Hzlm+q7BDwAVxN2XRZKSdd6s2RfEIrss=; b=kqYx6LboH6iM7akDdklwAuJFHwgAiF3xNvtPLOMgIsbTdvX34tRCoc9lH28V4Vs+SQ KTQ8Ic/Zuy9PRmiq7WafBMn8SoO/qVJc7oqFQq7BkndVjxuKBua0bxDodyLjPPOchR/0 po7cIGtqQVnTer6j1/0fRGX+qQvdMJgxbn4+anpdSghW1IZYF1S7REzt8NxrFZuDoogJ h2pnhatu8yR3sK3pL09ufsdUzoHJaUOmKUn8hdxmHyZH3zS4F69n2gjXK5bQ3Hy1QmE3 B8YPmPhi6hD/v0HLi1jfj2+yD34hqU4DwB7hNcRE+X64pu4fQ+BXZkbXfmLhZLdsGDeK MGLw== X-Forwarded-Encrypted: i=1; AHgh+Rp4g7lkIu952ojOkhJ/6TWk3QSr/yKZy/vvedXwzpzWflAajrL28/dcw7ygVAnOq6KUwv8=@sourceware.org X-Gm-Message-State: AOJu0YxsopaOk17vSeR8xzVgqH6p9oQGKnVQJ91LJNs3wQG6o7uzwNJ1 t9zjIVfNI7PX1BB0tr/bWNk29MlFhUbIha0dmGgxdDRQSFMzOqjk8VfySi366joTZJM= X-Gm-Gg: AR+sD13M2IWZniPXJKzufffaXP3UtJeWueDusXkrWDU5GqWcoNmfm8j1Zv2sr0cM8GT 1dG24jpI03PjSEKEl6KudXwXLcf9tPNd7yBtUlNcb8ASW+m6jE2nrzndquRDTgVSjY79K0PgrSf 0nIl4KiqSF89rJs5BXnFolu9mUC10d0h7nycLWMiWQCca6oyDfpyldHesZZsIvIIF/YFosh4LhQ wqAE/89z9ybZVmzgoQKCoWNObVYnciFl5sPBfEt4UVXZz7/cjPhbngVsKztdwBnWNBeoRls91Js BlP5i2lo1jk/ceTI4e/gSm0LRtDYugqw1i04lnipBLMPIv1GxeMAUHegr6yrTiu66VECICUJ4Y0 CIyGEuduLZf/Qu5wBaW0Fxb0xdv/uZ3S7O6hFJ0xtJIRuM2euZYffeCdS6pTGWmJYJbhfxGwjl7 4DhYnZtgrglEx2paD76Av9bR5G7xorcd5R2LlMX1xjgqcd4nmNlnAuvnvFgkfJl4+pSntk8z2+D qGY1nYOI4l9irVaIlgdvC8xnYxGbGnIpCATWjeY6Y3BWp2UMPvXR4Y4kMIzcKRCfw== X-Received: by 2002:a05:6a00:23c5:b0:848:2a69:97be with SMTP id d2e1a72fcca58-84fa186ba38mr19668b3a.10.1786382729490; Mon, 10 Aug 2026 10:25:29 -0700 (PDT) Received: from lima-default.tail89d63.ts.net (61-222-153-199.hinet-ip.hinet.net. [61.222.153.199]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a5898f8sm4149949b3a.52.2026.08.10.10.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 10:25:29 -0700 (PDT) To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Oleg Nesterov , linux-riscv@lists.infradead.org Cc: andybnac@gmail.com, Andy Chiu , Sergey Matyukevich , gdb@sourceware.org, dfustini@oss.tenstorrent.com, greentime.hu@sifive.com, daichengrong , Yong-Xuan Wang , Deepak Gupta Subject: [PATCH v5 5/7] riscv: vector: adjust ptrace and signal behavior for INITIAL state Date: Mon, 10 Aug 2026 12:22:32 -0500 Message-ID: <20260810172255.1532787-6-tchiu@tenstorrent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810172255.1532787-1-tchiu@tenstorrent.com> References: <20260810172255.1532787-1-tchiu@tenstorrent.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andy Chiu via Gdb Reply-To: Andy Chiu Errors-To: gdb-bounces~public-inbox=simark.ca@sourceware.org Sender: "Gdb" The last patch introduced the INITIAL vector state to avoid saving and restoring vector registers across syscall boundaries. However, this optimization did not fully account for the ptrace and signal handling interfaces. As a result, two issues emerged: 1. Ptrace reads at syscall stop could observe stale, non-nulled registers. 2. Modifications to the ucontext through signal interface during a syscall stop would be overwritten by the vector discaring macro. This patch introduces riscv_v_ucontext_save() to synchronize these paths with the INITIAL state: - Ptrace reads during a syscall stop now explicitly execute the hardware discard macro and return the discarded state to prevent data leaks. - Ptrace writes (PTRACE_SETREGSET) during a syscall stop are silently dropped (returning 0). Returning an error like EINVAL would break debbugers like GDB, which disables the optional regset on receiving such error. - Signal handling (rt_sigreturn) now honor user-space modifications to the vector context (for user-space thread schedulers). CC: Sergey Matyukevich CC: gdb@sourceware.org Signed-off-by: Andy Chiu --- Changelog v3: - new patch since v3 --- arch/riscv/include/asm/vector.h | 2 ++ arch/riscv/kernel/ptrace.c | 13 ++++++------ arch/riscv/kernel/signal.c | 11 ++++++---- arch/riscv/kernel/vector.c | 37 +++++++++++++++++++++++++++++++++ 4 files changed, 53 insertions(+), 10 deletions(-) diff --git a/arch/riscv/include/asm/vector.h b/arch/riscv/include/asm/vector.h index 355104336c70..2e6b88e35664 100644 --- a/arch/riscv/include/asm/vector.h +++ b/arch/riscv/include/asm/vector.h @@ -61,6 +61,7 @@ void riscv_v_thread_free(struct task_struct *tsk); void __init riscv_v_setup_ctx_cache(void); void riscv_v_thread_alloc(struct task_struct *tsk); void __init update_regset_vector_info(unsigned long size); +void riscv_v_ucontext_save(struct task_struct *tsk); static inline u32 riscv_v_flags(void) { @@ -437,6 +438,7 @@ static inline bool riscv_v_vstate_ctrl_user_allowed(void) { return false; } #define riscv_v_thread_alloc(tsk) do {} while (0) #define get_cpu_vector_context() do {} while (0) #define put_cpu_vector_context() do {} while (0) +#define riscv_v_ucontext_save(tsk) do {} while (0) #define riscv_v_vstate_set_restore(task, regs) do {} while (0) #endif /* CONFIG_RISCV_ISA_V */ diff --git a/arch/riscv/kernel/ptrace.c b/arch/riscv/kernel/ptrace.c index f336a183667e..9276485b6cac 100644 --- a/arch/riscv/kernel/ptrace.c +++ b/arch/riscv/kernel/ptrace.c @@ -109,11 +109,7 @@ static int riscv_vr_get(struct task_struct *target, * Ensure the vector registers have been saved to the memory before * copying them to membuf. */ - if (target == current) { - get_cpu_vector_context(); - riscv_v_vstate_save(¤t->thread.vstate, task_pt_regs(current)); - put_cpu_vector_context(); - } + riscv_v_ucontext_save(target); ptrace_vstate.vstart = vstate->vstart; ptrace_vstate.vl = vstate->vl; @@ -222,13 +218,18 @@ static int riscv_vr_set(struct task_struct *target, int ret; struct __riscv_v_ext_state *vstate = &target->thread.vstate; struct __riscv_v_regset_state ptrace_vstate; + struct pt_regs *regs = task_pt_regs(target); if (!(has_vector() || has_xtheadvector())) return -EINVAL; - if (!riscv_v_vstate_query(task_pt_regs(target))) + if (!riscv_v_vstate_query(regs)) return -ENODATA; + /* Silently drop the modification to tracee as no vreg lives across a syscall */ + if (__riscv_v_vstate_check(regs->status, INITIAL)) + return 0; + /* Copy rest of the vstate except datap */ ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &ptrace_vstate, 0, sizeof(struct __riscv_v_regset_state)); diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c index 59784dc117e4..0da352310b84 100644 --- a/arch/riscv/kernel/signal.c +++ b/arch/riscv/kernel/signal.c @@ -89,9 +89,7 @@ static long save_v_state(struct pt_regs *regs, void __user *sc_vec) /* datap is designed to be 16 byte aligned for better performance */ WARN_ON(!IS_ALIGNED((unsigned long)datap, 16)); - get_cpu_vector_context(); - riscv_v_vstate_save(¤t->thread.vstate, regs); - put_cpu_vector_context(); + riscv_v_ucontext_save(current); /* Copy everything of vstate but datap. */ err = __copy_to_user(&state->v_state, ¤t->thread.vstate, @@ -121,9 +119,14 @@ static long __restore_v_state(struct pt_regs *regs, void __user *sc_vec) /* * Mark the vstate as clean prior performing the actual copy, * to avoid getting the vstate incorrectly clobbered by the - * discarded vector state. + * discarded vector state. + * + * This also allows user to modify vregs through the signal + * interface at a syscall stop. e.g. to support user space + * context switching. */ riscv_v_vstate_set_restore(current, regs); + __riscv_v_vstate_clean(regs); /* Copy everything of __sc_riscv_v_state except datap. */ err = __copy_from_user(¤t->thread.vstate, &state->v_state, diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c index 4eef51f6d432..6fd541f5d5cb 100644 --- a/arch/riscv/kernel/vector.c +++ b/arch/riscv/kernel/vector.c @@ -29,6 +29,43 @@ static struct kmem_cache *riscv_v_kernel_cachep; unsigned long riscv_v_vsize __read_mostly; EXPORT_SYMBOL_GPL(riscv_v_vsize); +/* + * Context memory is not coherent to register when sstatus.vs is set to INITIAL. This function + * take the INITIAL state into consideration and reflect the nulled state into context memory. + * Assume the target task is not actively running when tsk != current + */ +void riscv_v_ucontext_save(struct task_struct *tsk) +{ + struct __riscv_v_ext_state *vstate = &tsk->thread.vstate; + struct pt_regs *regs = task_pt_regs(tsk); + + /* + * Do not set vstate as clean when it is INITIAL, otherwise we lose track of the nulled + * state in ptrace. + */ + if (tsk == current) { + get_cpu_vector_context(); + if (__riscv_v_vstate_check(regs->status, INITIAL)) { + riscv_v_enable(); + __riscv_v_vstate_discard(); + __riscv_v_vstate_save(vstate, vstate->datap); + riscv_v_disable(); + } else { + riscv_v_vstate_save(vstate, regs); + } + put_cpu_vector_context(); + } else if (__riscv_v_vstate_check(regs->status, INITIAL)) { + /* + * If we are not current and VS == INITIAL, null out the context memory for tsk + * using kernel mode vector. + */ + kernel_vector_begin(); + __riscv_v_vstate_discard(); + __riscv_v_vstate_save(vstate, vstate->datap); + kernel_vector_end(); + } +} + int riscv_v_setup_vsize(void) { unsigned long this_vsize; -- 2.43.0