Re: Proposal: Add review tags to patch review workflow.

John Baldwin
2022-09-27T17:11:53Z

On 9/27/22 5:03 AM, Bruno Larsen wrote:
> On 27/09/2022 14:02, Simon Marchi wrote:
>>
>>>> It also wasn't clear to me if the intention was for the commits to
>>>> be amended with the annotations?  (I don't think it was explicitly
>>>> stated in the original mail, and I'm not sure if it was an implicit
>>>> assumption?)
>>> No, I didn't intend on amending previous commits. The main problem this change intends to solve is fixing ambiguity, and the pushed patches don't have that issue anymore. Thanking a reviewer is just one more positive side (IMHO) going forward.
>> Err, just to be clear, we won't amend existing commits in master
>> obviously (can't rewrite history) but future commits in master would
>> contain those tags. This means that if you give me a Reviewed-By, I
>> amend my local commit patch to include that trailer before pushing.
> Yes, thank you for clarifying what I meant!

Yes, my question was about amending the in-progress commits before
pushing, not existing history.

If we weren't amending commits then you could perhaps omit the e-mail
address (it's implicit from the From), but the full tag is better to
copy/paste into a commit log or git commit --trailer

--
John Baldwin