From: Bob Rossi <bob@brasko.net>
To: gdb@sourceware.org
Subject: Re: source annotation now prints source line
Date: Tue, 14 Apr 2020 07:23:04 -0400 [thread overview]
Message-ID: <20200414112304.GB22764@xubuntu.brasko.net> (raw)
In-Reply-To: <20200404235424.GB5321@xubuntu.brasko.net>
On Sat, Apr 04, 2020 at 07:54:24PM -0400, Bob Rossi wrote:
> When the source annotation is sent to the front end, the source line
> is now also sent to the front end console. I believe this commit
> introduced it,
> https://github.com/bminor/binutils-gdb/commit/ec8e2b6d3051f0b4b2a8eee9917898e95046c62f
>
> Now CGDB displays,
> (gdb) n
> 43 int i = 3;
> (gdb)
>
> Instead of,
> (gdb) n
> (gdb)
>
> CGDB is a front end, and so it has a source view to display the code to
> the user. Why did GDB decide to also print the line of code to the front
> end's console window as well? This is confusing.
The concept behind this commit seems incorrect.
The motivation for the patch isn't clearly explained in
the commit message. I believe I've given a reasonable explanation
on why this patch makes no sense for front ends.
Should I submit a patch reverting it?
Thanks,
Bob Rossi
next prev parent reply other threads:[~2020-04-14 11:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-04 23:54 Bob Rossi
2020-04-14 11:23 ` Bob Rossi [this message]
2020-04-14 12:17 ` Andrew Burgess
2020-04-14 12:57 ` Andrew Burgess
2020-04-15 2:13 ` Bob Rossi
2020-04-16 17:41 ` Andrew Burgess
2021-03-13 17:01 ` Bob Rossi
2021-03-15 13:10 ` Pedro Alves via Gdb
2024-05-04 20:09 ` Robert Rossi
2024-05-05 15:36 ` Robert Rossi
2024-05-05 16:06 ` Eli Zaretskii via Gdb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414112304.GB22764@xubuntu.brasko.net \
--to=bob@brasko.net \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox