From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22630 invoked by alias); 17 Dec 2019 06:01:13 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 22385 invoked by uid 89); 17 Dec 2019 06:00:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=905020191206, 9.0.50.20191206, H*f:sk:DB6PR05, H*f:sk:ccdcc5e X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2019 06:00:54 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A95F4116445; Tue, 17 Dec 2019 01:00:52 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id UXc4nuBEKo9d; Tue, 17 Dec 2019 01:00:52 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CEFA511643B; Tue, 17 Dec 2019 01:00:51 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8B8F6897CD; Tue, 17 Dec 2019 10:00:47 +0400 (+04) Date: Tue, 17 Dec 2019 06:01:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Tom Tromey , Simon Marchi , Wadud Miah , "gdb@sourceware.org" Subject: Re: building GDB 9.0.50.20191206 Message-ID: <20191217060047.GA3582@adacore.com> References: <20191212140954.GC8591@adacore.com> <878sngvvub.fsf@tromey.com> <986c3939-b6fd-b973-0ccb-1bd91f097df2@simark.ca> <871rt7vme9.fsf@tromey.com> <87h821ef6w.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h821ef6w.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-12/txt/msg00030.txt.bz2 > Tom> Review here: > Tom> https://sourceware.org/ml/gdb-patches/2019-08/msg00433.html > Tom> Maybe some comments there still need to be addressed. I can't recall > Tom> offhand. > > I've updated my patch and re-read the thread. > > The remaining issue is that I still haven't decided what to do about > in files like nat/linux-btrace.c. The message referred to > above outlines the various approaches and their problems pretty well. Thanks Tom. Going back to Simon's question about what to do for the release, I tend to agree with you that it's an unnecessary risk to be trying to finish the transition of moving the directories to the root directory. Could we add a test that checks explicitly for in-tree builds and abort with a clear error message when detected? Is there an in-tree/out-of-tree check that already exists for that? Otherwise, I'd base it on the src_dir being different from the build dir, but that's simple-minded and pretty easy to defeat (not that it's a huge issue). -- Joel