Re: contributing the RISC-V linux native port

Jim Wilson
2018-08-07T16:14:11Z

On Tue, Aug 7, 2018 at 6:01 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> I don't think we have a specific guideline for this; my opinion is
> that you don't have to wait for something to be perfect before you
> can submit it for inclusion. What you want to ask yourself is,
> assuming your patch is improving things already (and therefore
> being helpful to you and probably others), does it have a cost
> elsewhere? For instance, will it make harder to fix something later,
> or does it break something else, etc? If, as is often the case,
> you find that the code is self contained and doesn't hurt anything
> else, why not submit it already, so others can benefit from it?
> As long as the code passes the coding standards, I don't see how
> it could hurt.

I don't expect that my patches will cause any problems. My patch is
improving things for me already. I've been able to use gdb to debug
binutils, gcc, and gdb issues. But I'm a command line guy, and don't
use any fancy gdb features, so I'm not sure how it will work for
others.

I've been advertising my personal github tree on riscv mailing lists
and irc, but haven't gotten any direct feedback yet. I did get some
indirect feedback in the form of a glibc patch from Andreas Schwab so
I suspect that he has tried it. My tree is at
https://github.com/jim-wilson/riscv-linux-native-gdb
if anyone wants to look at it. See the README.md file.

I'll work on a patch set for submission.

Jim