From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120701 invoked by alias); 13 Sep 2017 21:33:16 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 120679 invoked by uid 89); 13 Sep 2017 21:33:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Sep 2017 21:33:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05E6D1529; Wed, 13 Sep 2017 14:33:13 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD4233F578; Wed, 13 Sep 2017 14:33:10 -0700 (PDT) Date: Wed, 13 Sep 2017 21:33:00 -0000 From: Dave Martin To: Catalin Marinas Cc: linux-arch@vger.kernel.org, libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , gdb@sourceware.org, Yao Qi , Will Deacon , Richard Sandiford , Alan Hayward , Alex =?iso-8859-1?Q?Benn=E9e?= , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 09/28] arm64/sve: Signal frame and context structure definition Message-ID: <20170913213307.GF23415@e103592.cambridge.arm.com> References: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> <1504198860-12951-10-git-send-email-Dave.Martin@arm.com> <20170913133618.lclorawve7364xxi@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170913133618.lclorawve7364xxi@localhost> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2017-09/txt/msg00036.txt.bz2 On Wed, Sep 13, 2017 at 06:36:18AM -0700, Catalin Marinas wrote: > On Thu, Aug 31, 2017 at 06:00:41PM +0100, Dave P Martin wrote: > > +/* > > + * The SVE architecture leaves space for future expansion of the > > + * vector length beyond its initial architectural limit of 2048 bits > > + * (16 quadwords). > > + */ > > +#define SVE_VQ_BYTES 0x10 /* number of bytes per quadword */ > > + > > +#define SVE_VQ_MIN 1 > > +#define SVE_VQ_MAX 0x200 > > Just a nitpick (up to you): could you use 16 and 512 here instead of > hex? I usually associate hex numbers with some bit fields. I have no strong opinion other than a desire to make these constants typo-proof. There's no particular reason why these shouldn't be in decimal, so I can change them if you like, provided you promise to notice if I misspell 512 as 521... (git grep 131027) Cheers ---Dave