From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94697 invoked by alias); 8 Sep 2017 13:11:49 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 94678 invoked by uid 89); 8 Sep 2017 13:11:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:721 X-Spam-User: qpsmtpd, 2 recipients X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Sep 2017 13:11:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C16CD13D5; Fri, 8 Sep 2017 06:11:45 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1D1203F578; Fri, 8 Sep 2017 06:11:42 -0700 (PDT) Date: Fri, 08 Sep 2017 13:11:00 -0000 From: Dave Martin To: "Okamoto, Takayuki" Cc: "linux-arch@vger.kernel.org" , "libc-alpha@sourceware.org" , Ard Biesheuvel , Szabolcs Nagy , "gdb@sourceware.org" , Yao Qi , Will Deacon , Oleg Nesterov , Alex =?iso-8859-1?Q?Benn=E9e?= , Richard Sandiford , Alexander Viro , Alan Hayward , Catalin Marinas , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 19/28] arm64/sve: ptrace and ELF coredump support Message-ID: <20170908131136.GG6321@e103592.cambridge.arm.com> References: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> <1504198860-12951-20-git-send-email-Dave.Martin@arm.com> <5FA513F682BE7F4EAAB8EE035D5B08E44109DFE8@G01JPEXMBKW02> <20170906181634.GF6321@e103592.cambridge.arm.com> <5FA513F682BE7F4EAAB8EE035D5B08E44109EBDF@G01JPEXMBKW02> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5FA513F682BE7F4EAAB8EE035D5B08E44109EBDF@G01JPEXMBKW02> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2017-09/txt/msg00025.txt.bz2 On Thu, Sep 07, 2017 at 05:11:45AM +0000, Okamoto, Takayuki wrote: > Hi Dave, > > Thank you for your reply. > > > Your fix looks correct and seems to work. For stylistic reasons, I may > > write it like this instead, but the effect should be the same: > > > > header->max_vl = sve_max_vl; > > if (WARN_ON(!sve_vl_valid(sve_max_vl)) > > header->max_vl = header->vl; > > It is better than my fix. > Please, apply it at next version. I've rebased to v4.13 and pushed a branch to track fixes against v2, here: * http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve/v2%2Bfixes * git://linux-arm.org/linux-dm.git sve/v2+fixes Cheers ---Dave