From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82663 invoked by alias); 22 Aug 2017 15:41:19 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 82637 invoked by uid 89); 22 Aug 2017 15:41:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=20pm, 20PM, Hx-languages-length:1115 X-Spam-User: qpsmtpd, 2 recipients X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Aug 2017 15:41:17 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5874313D5; Tue, 22 Aug 2017 08:41:16 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 210C63F577; Tue, 22 Aug 2017 08:41:13 -0700 (PDT) Date: Tue, 22 Aug 2017 15:41:00 -0000 From: Dave Martin To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: linux-arch@vger.kernel.org, libc-alpha@sourceware.org, Ard Biesheuvel , Szabolcs Nagy , gdb@sourceware.org, Yao Qi , Alan Hayward , Will Deacon , Richard Sandiford , Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/27] arm64/sve: Signal frame and context structure definition Message-ID: <20170822154111.GW6321@e103592.cambridge.arm.com> References: <1502280338-23002-1-git-send-email-Dave.Martin@arm.com> <1502280338-23002-10-git-send-email-Dave.Martin@arm.com> <87y3qb52ez.fsf@linaro.org> <20170822111705.GT6321@e103592.cambridge.arm.com> <87tw0z4sk2.fsf@linaro.org> <20170822142135.GU6321@e103592.cambridge.arm.com> <87shgj4pc7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87shgj4pc7.fsf@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2017-08/txt/msg00053.txt.bz2 On Tue, Aug 22, 2017 at 04:03:20PM +0100, Alex Bennée wrote: > > Dave Martin writes: > > > On Tue, Aug 22, 2017 at 02:53:49PM +0100, Alex Bennée wrote: [...] > >> + > >> +#define SVE_VQ_BITS 128 /* 128 bits in one quadword */ > >> +#define SVE_VQ_BYTES (SVE_VQ_BITS / 8) > >> + > > > > I was trying to keep extraneous #defines to a minimum, since this is a > > uapi header, and people may depend on anything defined here. > > > > I think SVE_VQ_BYTES is reasonable to have, and this allows us to > > rewrite a few hard-coded 0x10s and 16s symbolically which is probably a > > good idea -- I'll add this. > > > > SVE_VQ_BITS looks redundant to me though. It wouldn't be used for any > > purpose other than defining SVE_VQ_BYTES. > > Yeah I was more concerned with getting rid of the magic 0x10's than > showing exactly how many bits something is. OK, I'll take SVE_VQ_BYTES and use it in the appropriate places. There are a few 0x10s/16s in the series that can use this instead of being open-coded. Cheers ---Dave