From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb <gdb@sourceware.org>
Subject: Re: Personal branches and restrictions with GIT repository
Date: Thu, 28 May 2015 13:44:00 -0000 [thread overview]
Message-ID: <20150528134408.GE3111@adacore.com> (raw)
In-Reply-To: <5566E465.3080909@redhat.com>
> So this boils down to two questions:
>
> 1) Do we need this hook for personal branches?
It's a hook aimed at users who are not very familiar with git
and who might accidently do a merge instead of a rebase.
Un understand that this can be felt as a PITA for more experienced
git users, but it is a really easy mistake to make when one is not
paying attention, and it is also quickly resolved.
>
> 2) And are users allowed to do whatever they want in their own
> personal branch (within sane defaults)?
To answer your two questions, I think it boils down to policy
rather than need. The hooks should accomodate the policy.
We can turn all pre-commit checks for user-branches. I don't believe
that the hooks, as currently implemented, support turning off just
that "accidental merge" check. The latter can, of course, be easily
implemented.
FWIW, my take is that if you're going to have your branch hosted
on the sourceware git, it's not a big effort to be following the same
guidelines as other official branches. But if people want it otherwise,
then we can adjust the hooks.
--
Joel
next prev parent reply other threads:[~2015-05-28 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 9:48 Phil Muldoon
2015-05-28 10:11 ` Matthew Fortune
2015-05-28 13:44 ` Joel Brobecker [this message]
2015-05-28 14:03 ` Phil Muldoon
2015-06-30 20:19 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528134408.GE3111@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox