Mirror of the gdb mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: gdb@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: python-injected silent breakpoints broken since 1a853c52
Date: Tue, 13 Jan 2015 14:39:00 -0000	[thread overview]
Message-ID: <20150113143935.GI8139@adacore.com> (raw)
In-Reply-To: <54B52A1B.1090409@siemens.com>

Jan,

> I've stumbled over a regression of gdb since commit 1a853c52 (make
> "permanent breakpoints" per location and disableable). My gdb python
> scripts [1] that load Linux kernel module symbols as the target loads
> the modules now fail.
> 
> The involved command is lx-symbols [2]. It installs a silent breakpoint
> on a kernel function that is called when a module is loaded. Before
> 1a853c52, the python callback was normally invoked and the target
> continued to run. Since af48d08f (1a853c52 is not testable), the int3
> instruction (I'm testing with x86) is left in the target, and garbage
> instructions are executed, causing a kernel oops. The breakpoint is
> apparently not properly skipped (remove, single-step, re-insert) when
> resuming the target on return from LoadModuleBreakpoint.stop().
> 
> I can provide more details on how to set up a reproduction case but I
> would only gather them when desired as that is not straightforward.
> 
> Jan
> 
> [1] https://lkml.org/lkml/2014/11/20/531
> [2]
> http://git.kiszka.org/?p=linux.git;a=blob;f=scripts/gdb/linux/symbols.py;h=bf05e451c58666add299061046bf1ceb9e82f4ef;hb=d92098e7cf60d31ccd025e56d20c23917ccd0819

Thanks for the report!

Can you please open a PR at the following URL?
https://sourceware.org/bugzilla/

There is a chance that we might consider this regression as
release blocking for GDB 7.9 (planned for the near future),
and having PR makes things a lot easier to track.

Thank you!
-- 
Joel


  reply	other threads:[~2015-01-13 14:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 14:22 Jan Kiszka
2015-01-13 14:39 ` Joel Brobecker [this message]
2015-01-13 14:43   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113143935.GI8139@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb@sourceware.org \
    --cc=jan.kiszka@siemens.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox