From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25187 invoked by alias); 15 Sep 2014 10:30:04 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 25174 invoked by uid 89); 15 Sep 2014 10:30:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Sep 2014 10:30:01 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8FATpaq003298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 15 Sep 2014 06:29:51 -0400 Received: from blade.nx (ovpn-116-123.ams2.redhat.com [10.36.116.123]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8FATo6m028578; Mon, 15 Sep 2014 06:29:51 -0400 Received: by blade.nx (Postfix, from userid 1000) id A3E4B2640D5; Mon, 15 Sep 2014 11:29:49 +0100 (BST) Date: Mon, 15 Sep 2014 10:30:00 -0000 From: Gary Benson To: Joel Brobecker Cc: Doug Evans , Pedro Alves , gdb , Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140915102949.GC13503@blade.nx> References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> <54102ED8.7060307@redhat.com> <20140910162853.GT13931@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140910162853.GT13931@adacore.com> X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00052.txt.bz2 Joel Brobecker wrote: > > > E.g., I suspect this patch: > > > > > > https://sourceware.org/ml/gdb-patches/2014-08/msg00650.html > > > > > > will end up with both Gary's and Tom's name in the ChangeLog, > > > but that's really just a guess. > > > > > > This makes it impossible for someone else to push the patch > > > other than the submitter, because not all the info is there. > > > > > > It's a bigger issue even if someone posts a patch written or > > > co-written by someone that might not have copyright > > > assignment in place. > > > > > > I think author info must be explicit in patch submissions > > > somehow. > > That's probably the strongest argument in favor of putting > the full ChangeLog entry in the revision log. I'm just having > a hard time accepting the fact that we going to include a date > in the revision log which could be wrong because added by hand. > And once it's pushed, there is no going back, so no way to fix it. > > Recognizing the fact that the majority of patches have one single > author who is also the submitter, perhaps we could use the no-date/ > no-author format for those cases, and provide a way to specify > for those few times where necessary? Seems complicated, perhaps... Optional authors lines below "path/to/ChangeLog:"? Introduce target/target.h This introduces target/target.h. This file declares some functions that the shared code can use and that clients must implement. It also changes some shared code to use these functions. gdb/ChangeLog: Tom Tromey Gary Benson * target/target.h: New file. * Makefile.in (HFILES_NO_SRCDIR): Add target/target.h. * target.h: Include target/target.h. ... gdb/gdbserver/ChangeLog: Tom Tromey Gary Benson * target.h: Include target/target.h. * target.c (target_read_memory, target_read_uint32) ... In terms of parsing, the "/ChangeLog:" marks the start of a ChangeLog entry, and the blank line marks the end of any optional authors lines. If no authors lines are present then the committer is the author. Cheers, Gary -- http://gbenson.net/