From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28279 invoked by alias); 4 Sep 2014 17:36:40 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 28268 invoked by uid 89); 4 Sep 2014 17:36:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Sep 2014 17:36:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s84HaQho014837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Sep 2014 13:36:26 -0400 Received: from blade.nx (ovpn-116-86.ams2.redhat.com [10.36.116.86]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s84HaPvw032081; Thu, 4 Sep 2014 13:36:25 -0400 Received: by blade.nx (Postfix, from userid 1000) id 97DA72640D8; Thu, 4 Sep 2014 18:36:24 +0100 (BST) Date: Thu, 04 Sep 2014 17:36:00 -0000 From: Gary Benson To: Doug Evans Cc: Sergio Durigan Junior , Andreas Schwab , Joel Brobecker , gdb , Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140904173624.GA10113@blade.nx> References: <20140814083231.GA6283@blade.nx> <20140814125224.GF4924@adacore.com> <8761h4fmu4.fsf@redhat.com> <87mwage6x2.fsf@redhat.com> <871trsuz55.fsf@igel.home> <20140904090616.GA23758@blade.nx> <87y4tzcvny.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00012.txt.bz2 Doug Evans wrote: > On Thu, Sep 4, 2014 at 7:22 AM, Sergio Durigan Junior > wrote: > > On Thursday, September 04 2014, Gary Benson wrote: > > > > There is no such thing as a "push date". What you see is the > > > > author date and the committer date. But both are set during > > > > the local commit, and are unrelated to the point of time of > > > > pushing the commits to the remote repository. > > > > > > Yeah, in git no file (object) is modified when you push or pull > > > commits, they're just copied from one place to another. > > > > Yeah, sorry for not being fluent in git's parlance. > > > > > The committer date on the commit you mentioned is likely the > > > time I updated the ChangeLog prior to pushing, so that date will > > > be the "push date", but that's not guaranteed to be the case for > > > all commits. > > > > Right. Anyway, I still consider it is valid to include this info > > (author and date) in the commit message. > > For reference sake, what started this for me is noticing git blame > shows the author date by default. > > Not picking on Gary of course, his patch is just > why I noticed this. > If I do a git blame of server.c I see patch 860789c7 with a date of > 2014-08-08. That's three weeks before it was pushed upstream. > Bleah. I'd really like to be able to do a git blame and have what > I see be useful, including the date. The author date is basically > useless to me. I see some options to git-rebase, --committer-date-is-author-date and --ignore-date. I'll experiment with these the next time I rebase something and see what happens. It's a shame there's no global option you can set to make git log, blame etc show the other date. > I realize any changes to what goes into the commit log won't help > solve this of course. But that's what started the discussion for > me. FAOD for changelog-in-commit messages, I'm equally happy with the format I used for 5ee44bfa (the current one described in the wiki) or the one I used to use (eg e76df0d0). I script all this anyway so any format I can script is fine by me. Thanks, Gary -- http://gbenson.net/