From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12696 invoked by alias); 27 Aug 2014 08:48:59 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 12666 invoked by uid 89); 27 Aug 2014 08:48:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Aug 2014 08:48:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7R8movu014583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Aug 2014 04:48:50 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7R8mnt5024445; Wed, 27 Aug 2014 04:48:49 -0400 Received: by blade.nx (Postfix, from userid 1000) id 382DE2640D7; Wed, 27 Aug 2014 09:48:49 +0100 (BST) Date: Wed, 27 Aug 2014 08:48:00 -0000 From: Gary Benson To: Joel Sherrill Cc: "gdb@sourceware.org" Subject: Re: Multiple Target Failures for Multiple Definition of debug_printf Message-ID: <20140827084849.GB4533@blade.nx> References: <53F60937.2030404@oarcorp.com> <53F614F3.9070307@oarcorp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F614F3.9070307@oarcorp.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00129.txt.bz2 Hi Joel, Sorry for the slow reply, I was on vacation. There is another thread about this, with a patch. I'll copy you in on it. Cheers, Gary Joel Sherrill wrote: > I hate to follow up to myself but the references to debug_printf() > in sim/ were the prototype, body, and multiple ChangeLog entries. > > I if 0'ed the sim/ debug_printf() out and bfin now links. > > Can someone else confirm that the debug_printf() under sim/ > is unused and can be deleted? > > Thanks. > > --joel > > On 8/21/2014 9:59 AM, Joel Sherrill wrote: > > Hi > > > > I reported this earlier but wanted to provide some more details. > > > > Multiple architectures fail when linking gdb due to debug_printf() > > being multiply defined. > > > > The architectures are: bfin, h8300, lm32, mips, moxie, and v850. > > > > The debug_printf() in gdb/common/common-debug.c is very > > simple. But the one in sim/common/sim-trace.c is more > > complicated and has awareness of the simulator state. > > Thus they can't be folded into one method. > > > > There are 7 calls to debug_printf() in the sim/ tree but 203 > > in the gdb/ tree. > > > > This all leads me to believe that the solution is to change > > the name of the debug_printf() in sim/ to something like > > sim_debug_printf(). > > > > Thoughts? > > > > -- > Joel Sherrill, Ph.D. Director of Research & Development > joel.sherrill@OARcorp.com On-Line Applications Research > Ask me about RTEMS: a free RTOS Huntsville AL 35805 > Support Available (256) 722-9985