From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23571 invoked by alias); 20 Aug 2014 12:20:01 -0000 Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org Received: (qmail 23554 invoked by uid 89); 20 Aug 2014 12:19:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 12:19:58 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KCJpXV016386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 08:19:51 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KCJo0E017975; Wed, 20 Aug 2014 08:19:50 -0400 Received: by blade.nx (Postfix, from userid 1000) id 769CB2640D5; Wed, 20 Aug 2014 13:19:49 +0100 (BST) Date: Wed, 20 Aug 2014 12:20:00 -0000 From: Gary Benson To: Joel Brobecker Cc: Doug Evans , Mike Frysinger , gdb@sourceware.org, Andreas Arnez Subject: Re: ChangeLogs in commit messages Message-ID: <20140820121949.GC26854@blade.nx> References: <20140815084819.GB30130@blade.nx> <20140815121102.GB6019@adacore.com> <20140815130913.GA1954@blade.nx> <20140815132816.GC6019@adacore.com> <20140815150202.GA5674@blade.nx> <20140815160829.GF6019@adacore.com> <20140818083110.GA18549@blade.nx> <20140818150510.GB4828@adacore.com> <20140818152724.GA26439@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140818152724.GA26439@blade.nx> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00095.txt.bz2 Gary Benson wrote: > Joel Brobecker wrote: > > > > I'm happy with this. Do you want the "ChangeLog" in the path? > > > > > > Me too. > > > > > > As for ChangeLog in the path, > > > Do you mean prepending entries with "gdb/ChangeLog" or > > > "testsuite/ChangeLog" instead of just "gdb/" or "testsuite/" ? > > > If so, I would say skip "ChangeLog", keep just, e.g., "testsuite/". > > > That's the existing convention. > > > > FWIW, I think that the extra "ChangeLog" bring 2 benefits: > > - it makes it clear we're starting a ChangeLog entry: > > - it reduces the chances of a false-positive when parsing > > the revision log for one or more CL entries. I found this out > > while developing a parser that I use in the context of > > the gdb release. > > > > Small bonus: When you modify the root ChangeLog file, the entry > > ends up looking like this... > > > > | ChangeLog: > > | > > | * file: description. > > I'm happy with this. I'll wait a day or so in case somebody objects, > and if not I'll update the wiki. I have updated the wiki: https://sourceware.org/gdb/wiki/ContributionChecklist#Properly_formatted_commit_messages Cheers, Gary -- http://gbenson.net/